Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - OD 0.9999 issue #84

Closed
2 tasks
pi0neerpat opened this issue Aug 22, 2023 · 2 comments
Closed
2 tasks

QA - OD 0.9999 issue #84

pi0neerpat opened this issue Aug 22, 2023 · 2 comments
Assignees
@alekseevaiana

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Aug 22, 2023 •
edited
Loading

OD borrowed was 10, but app is showing 9.99955

  • Check what happened on-chain
  • Update the app rounding, if thats what caused the issue
@pi0neerpat pi0neerpat self-assigned this Aug 22, 2023
@pi0neerpat pi0neerpat mentioned this issue Aug 22, 2023
Closed
@pi0neerpat
Copy link
Member Author

The actual amount was 10 OD https://goerli.arbiscan.io/tx/0x7b5613baf41bfb94c30a41a3513aaf212a571dedf3bea73d2f4b91d06f4a4598

So some incorrect rounding is happening in the app

@alekseevaiana
Copy link
Member

It seems that we get this string with decimals from the API, so our formatting functions not causing the issue.

I put console.log in safes.ts in fetchUserSafes function and got this response:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alekseevaiana alekseevaiana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pi0neerpat @alekseevaiana