Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI Optimism tweaks #59

Closed
pi0neerpat opened this issue Mar 13, 2024 · 1 comment · Fixed by #58
Closed

HAI Optimism tweaks #59

pi0neerpat opened this issue Mar 13, 2024 · 1 comment · Fixed by #58
Assignees

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Mar 13, 2024

There are two remaining tasks to enable our SDK to work seamlessly with HAI on Optimism. Please address the following items, using branch add-optimism-hai

  1. src/virtual/virtualAnalyticsData.ts has a call vault721.totalSupply to fetch the total number of vaults. This is incompatible, since HAI does not have a vault721 contract. Will need to research how they are fetching total vaults and implement a switch statement to use the other method when on Optimism.
  2. src/geb.ts has a call to check if a user has a proxy. We updated our PROXY_REGISTRY and renamed the function from proxies to getProxy. Update the function getProxyAction to properly call proxyRegistry.proxies when on Optimism.

To test the results, run the app on Optimism from branch optimism-hai. Don't forget to yarn link the sdk and build.

Once this issue is completed, I can update the bot to support HAI, and also deploy a second interface for HAI using our od-app 🎉

Resources:

https://solidity-by-example.org/

@pi0neerpat
Copy link
Member Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants