Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ".finally()" #1

Merged
merged 1 commit into from Sep 26, 2022
Merged

feat: support ".finally()" #1

merged 1 commit into from Sep 26, 2022

Conversation

kettanaito
Copy link
Member

  • Adds support for .finally() method on the deferred promise.
  • Fixes an issue when catching an exception would still treat the deferred promise as unhandled (re-assign this.promise in the then/catch/finally methods).
  • Adds JSDoc descriptions for the .then(), .catch(), and .finally() methods.

@kettanaito kettanaito merged commit 1fcebb2 into main Sep 26, 2022
@kettanaito kettanaito deleted the feat/finally branch September 26, 2022 10:15
@kettanaito
Copy link
Member Author

Released: v1.1.0 🎉

This has been released in v1.1.0!

Make sure to always update to the latest version (npm i @open-draft/deferred-promise@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant