Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter geometry loading from DataCube.aggregate_spatial #581

Open
soxofaan opened this issue Jun 25, 2024 · 1 comment
Open

Smarter geometry loading from DataCube.aggregate_spatial #581

soxofaan opened this issue Jun 25, 2024 · 1 comment

Comments

@soxofaan
Copy link
Member

DataCube.aggregate_spatial(geometries) currently allows geometries to be a string or pathlib.Path, but then it assumes this is a backend-side path and "loads" this with non-standard read_vector.

It would be better (more user friendly, and more standard) to be a bit smarter here:

  • check if the string is a GeoJSON dump and load it like that
  • check if the string/path is a valid local (GeoJSON) file and load geometry from that

Also

  • start deprecating the current read_vector code path
  • share this feature with other geometry related processes
  • document this feature better
@soxofaan
Copy link
Member Author

(this was triggered from https://discuss.eodc.eu/t/aggregate-spatial/766)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant