Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add in-memory provider to SDK #165

Closed
Tracked by #126
toddbaert opened this issue Dec 21, 2023 · 12 comments · Fixed by #232
Closed
Tracked by #126

[FEATURE] add in-memory provider to SDK #165

toddbaert opened this issue Dec 21, 2023 · 12 comments · Fixed by #232
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 21, 2023

Add InMemoryProvider to SDK. See spec.

Tasks:

  • add provider
  • add tests
  • replace e2e tests here with InMemoryProvider.

see Java equivalent.

Parent issue: #126

@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 21, 2023
@toddbaert toddbaert changed the title add in-memory provider: https://openfeature.dev/specification/appendix-b [FEATURE] add in-memory provider to SDK Dec 21, 2023
@CommCody
Copy link
Contributor

fwiw @toddbaert I'm looking at this, limited bandwidth, but interested in completing this

@toddbaert
Copy link
Member Author

Hey @CommCody ! I've assigned you.

It's no problem if this takes some time. I'll keep it assigned to you for now.

@NeerajGartia21
Copy link

@CommCody are you working on this?
This issue looks interesting and I will be happy to collaborate with you.

@CommCody
Copy link
Contributor

Mildly, I do have some work on my fork. My time is limited however, so I'm not very actively working on it.

@NeerajGartia21
Copy link

Can I continue from where you left?

@toddbaert
Copy link
Member Author

Can I continue from where you left?

@NeerajGartia21 if @CommCody has a partial implementation, maybe you'd be better off working on the Java reconnect tests, or on the Error enhancements in JS you recently commented on.

@NeerajGartia21
Copy link

Cool, that sounds good.

@askpt askpt added this to the spec v0.7.0 milestone Jan 18, 2024
@CommCody
Copy link
Contributor

Hi @toddbaert I was updating my code to further implement this issue, but now I can't build the main branch anymore. the build fails with:

E:\openfeature-dotnet-sdk\test\OpenFeature.Tests\OpenFeature.Tests.csproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to refer
ence them from your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs
E:\openfeature-dotnet-sdk\src\OpenFeature\OpenFeature.csproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to reference them fro
m your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs [E:\openfeature-dotnet-sdk\test\OpenFeature.Tests\OpenFeature.Tests.csproj]

If I disable the following line in Directory.Packages.props my issues are gone:

    <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />

I have the following sdk installed: 8.0.101

@austindrenski
Copy link
Member

Thanks @CommCody, there was a similar report over the weekend, so looking into this.

@CommCody
Copy link
Contributor

Fwiw I'm running these commands on windows 11. Directly against the dotnet cli.

@toddbaert
Copy link
Member Author

@CommCody Hey! Unfortunately this has become a bit of a blocker.

If you aren't able to finish this in the next few days, would you mind if I take it over? I'm glad to pick up where you left off if you give me a branch, and will maintain as much of your work as possible, and make you a commit co-author.

@CommCody
Copy link
Contributor

CommCody commented Feb 5, 2024

Hi @toddbaert , totally fair
I've had some illness going around in the family, so I've been distracted.

My current state of work is here https://github.com/CommCody/dotnet-sdk/tree/add-in-memory-provider

From memory:

  • one test fails
  • some new public apis have no, or no decent documentation
  • basic structure from java was followed, but divergence for open generic type usage

KR
Joris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants