Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing/nil custom variables in fractional operator #1295

Merged

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Apr 19, 2024

This PR

Fixes #1285

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner April 19, 2024 17:53
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 797bbd4
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6622af962f641e0008e5e868

@Kavindu-Dodan Kavindu-Dodan changed the title fix:missing/nil custom variables in fractional operator fix: missing/nil custom variables in fractional operator Apr 19, 2024
@open-feature open-feature deleted a comment from github-actions bot Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.25%. Comparing base (1c530ab) to head (797bbd4).
Report is 54 commits behind head on main.

Files Patch % Lines
core/pkg/evaluator/fractional.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
+ Coverage   73.69%   77.25%   +3.56%     
==========================================
  Files          32       20      -12     
  Lines        3140     1618    -1522     
==========================================
- Hits         2314     1250    -1064     
+ Misses        717      286     -431     
+ Partials      109       82      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kavindu-Dodan Kavindu-Dodan merged commit 418c5cd into open-feature:main Apr 19, 2024
16 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Kavindu-Dodan pushed a commit that referenced this pull request Apr 19, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.10.1</summary>

##
[0.10.1](flagd/v0.10.0...flagd/v0.10.1)
(2024-04-19)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.9.0
([#1281](#1281))
([3cfb052](3cfb052))


### ✨ New Features

* move json logic operator registration to resolver
([#1291](#1291))
([b473457](b473457))
</details>

<details><summary>flagd-proxy: 0.6.1</summary>

##
[0.6.1](flagd-proxy/v0.6.0...flagd-proxy/v0.6.1)
(2024-04-19)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.9.0
([#1281](#1281))
([3cfb052](3cfb052))
</details>

<details><summary>core: 0.9.1</summary>

##
[0.9.1](core/v0.9.0...core/v0.9.1)
(2024-04-19)


### 🐛 Bug Fixes

* missing/nil custom variables in fractional operator
([#1295](#1295))
([418c5cd](418c5cd))


### ✨ New Features

* move json logic operator registration to resolver
([#1291](#1291))
([b473457](b473457))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fraction operation - add validations for nil values
3 participants