chore: flagd add offline flag source path support through env variables #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
beeme1mr
approved these changes
Jan 23, 2024
thisthat
approved these changes
Jan 24, 2024
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java
Show resolved
Hide resolved
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
toddbaert
approved these changes
Jan 25, 2024
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #646 by adding
FLAGD_OFFLINE_FLAG_SOURCE_PATHenv variable to set offline mode's flag source path.Logic is improved to handle null and documentation was updated to have consistency across languages.