Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JUnit Pioneer as testing dependency #820

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Jun 11, 2024

JUnit Pioneer offers a great set of additional utilities for JUnit tests, like setting env variables, setting system properties, default locales, etc. This could be a great extension of our testing capabilities without adding another dependency for our provided libraries.

closes: #818

closes: open-feature#818
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Copy link
Collaborator

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good additon to improve tests :)

@Kavindu-Dodan
Copy link
Collaborator

@aepfli could you please rebase the branch ?

@aepfli
Copy link
Member Author

aepfli commented Jun 14, 2024

@aepfli could you please rebase the branch ?

Affirmative ^^ and done ;)

@Kavindu-Dodan Kavindu-Dodan merged commit 3a9c916 into open-feature:main Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] add JUnit Pioneer to dev dependencies
5 participants