Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Implement domain scoping #843

Open
6 tasks
beeme1mr opened this issue Mar 15, 2024 · 5 comments · May be fixed by #934
Open
6 tasks

[FEATURE] Implement domain scoping #843

beeme1mr opened this issue Mar 15, 2024 · 5 comments · May be fixed by #934
Assignees
@jarebudev
Labels
contribfest A good issue for Contribfest KubeCon EU '24 help wanted Extra attention is needed v0.8.0
Milestone
Spec 0.8 Compliance

Comments

@beeme1mr
Copy link
Member

Overview

A domain is an identifier that logically binds clients with providers, allowing multiple providers to be used simultaneously within a single application.

Domains were added to the spec in the following PR: open-feature/spec#229

Tasks

Tasks
Beta Give feedback

Reference implementations

Support was added in the JS SDK here and the Python SDK here.

Note

Some SDKs support named clients which predate domains. The domain term is intended to clarify intended behavior.
@beeme1mr beeme1mr added this to the Spec 0.8 Compliance milestone Mar 15, 2024
@toddbaert toddbaert added the contribfest A good issue for Contribfest KubeCon EU '24 label Mar 15, 2024
@jarebudev
Copy link
Contributor

I can pick this one up

@toddbaert
Copy link
Member

toddbaert commented Apr 17, 2024 •
edited

@jarebudev Feel free. This is honestly mostly done in Java, the problem is we don't use the "domain" term. Right now we use "name" or "clientName" instead... I think all the functionality is there but poorly named. For example, this method just needs it's param and doc updated (name should be domain).

If your interested in taking it on I will assign.

@toddbaert toddbaert added the help wanted Extra attention is needed label Apr 23, 2024
@jarebudev
Copy link
Contributor

Yeh I can work on this. When I first looked at it there didn't appear to be a huge amount of change needed for this as you say mostly a tidy-up.

@toddbaert
Copy link
Member

@jarebudev 🙏 assigned

@jarebudev
Copy link
Contributor

as a fyi - had some other things to work on which had taken up my time. Should get a PR in this week.

@jarebudev jarebudev linked a pull request May 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarebudev jarebudev

Labels
contribfest A good issue for Contribfest KubeCon EU '24 help wanted Extra attention is needed v0.8.0
Projects
None yet
Milestone
Spec 0.8 Compliance
Development

Successfully merging a pull request may close this issue.

feat: implement domain scoping jarebudev/java-sdk
3 participants
@beeme1mr @jarebudev @toddbaert