Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor pod webhook mutator #410

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 21, 2023

This PR

makes some refactoring to prepare for kuttl tests implementation

  • refactor pod mutator to reduce the complexity of the handler function

Related Issues

part of #391

Signed-off-by: realanna <anna.reale@dynatrace.com>
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #410 (e4587f5) into main (42f9b00) will increase coverage by 0.01%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   71.29%   71.31%   +0.01%     
==========================================
  Files          11       11              
  Lines         836      847      +11     
==========================================
+ Hits          596      604       +8     
- Misses        213      215       +2     
- Partials       27       28       +1     
Impacted Files Coverage Δ
webhooks/pod_webhook.go 83.62% <84.21%> (-0.32%) ⬇️
Flag Coverage Δ
component-tests 65.04% <84.21%> (+0.13%) ⬆️
unit-tests 20.77% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are good function extractions.

@beeme1mr beeme1mr merged commit 2a86b03 into open-feature:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants