Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ignored renovate paths #441

Merged
merged 1 commit into from
Apr 3, 2023
Merged

chore: remove ignored renovate paths #441

merged 1 commit into from
Apr 3, 2023

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Apr 3, 2023

This PR

  • removes ignored renovate paths

Notes

Renovate must update some e2e test assertions when flagd is updated.

@beeme1mr
chore: remove ignored renovate paths
9a03a23 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from a team as a code owner April 3, 2023 16:40
Kavindu-Dodan
Kavindu-Dodan approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

Note - Originally introduced throuhg #395 . Intention should have been to improve renovate scanning performance by ignoring test files. However, latest tests need this scanning.

@toddbaert
Copy link
Member

Approving

Note - Originally introduced throuhg #395 . Intention should have been to improve renovate scanning performance by ignoring test files. However, latest tests need this scanning.

Adding to what @Kavindu-Dodan said for posterity: specifically some tests assert a particular version of flagd: https://github.com/open-feature/open-feature-operator/blob/main/test/e2e/kuttl/inject-flagd/01-assert.yaml#L17

@toddbaert toddbaert self-requested a review April 3, 2023 16:47
@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Merging #441 (9a03a23) into main (6f1f93c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files          21       21           
  Lines        1323     1323           
=======================================
  Hits         1032     1032           
  Misses        251      251           
  Partials       40       40
Flag Coverage Δ
unit-tests 78.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@beeme1mr beeme1mr merged commit c1d8929 into main Apr 3, 2023
@beeme1mr beeme1mr deleted the beeme1mr-patch-1 branch April 3, 2023 16:53
@github-actions github-actions bot mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beeme1mr @toddbaert @Kavindu-Dodan