Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Requirement 1.3.4 (type mismatch check in client) #126

Open
maxveldink opened this issue Apr 22, 2024 · 2 comments
Open

Implement Requirement 1.3.4 (type mismatch check in client) #126

maxveldink opened this issue Apr 22, 2024 · 2 comments

Comments

@maxveldink
Copy link
Member

maxveldink commented Apr 22, 2024

While reviewing #124, I realized that we were doing too much work in our InMemoryProvider implementation for verifying type mismatches. In fact, Requirement 1.3.4 indicates that the client should ultimately be checking this for any provider so we don't need to put this guarantee in the individual provider implementations.

We should ensure this requirement is implemented in the client. Then, we should simplify the InMemoryProvider.

@mschoenlaub
Copy link
Contributor

We should ensure this requirement is implemented in the provider..
@maxveldink
Shouldn't this say client?

@maxveldink
Copy link
Member Author

Yes, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants