Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS spec incorrect for validation_plugin_list #3537

Closed
2 tasks done
CharString opened this issue Oct 13, 2023 · 1 comment
Closed
2 tasks done

OAS spec incorrect for validation_plugin_list #3537

CharString opened this issue Oct 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CharString
Copy link
Contributor

CharString commented Oct 13, 2023

Product versie / Product version

78b2a74

Omschrijf het probleem / Describe the bug

It says it filters on componentType query parameter, but the service actually filters on component_type

The javascript function drops the parameter

export const getValidatorPlugins = async componentType => {
const resp = await get('/api/v2/validation/plugins');
return resp.data;
};

So it doesn't look used.

Stappen om te reproduceren / Steps to reproduce

  1. http://127.0.0.1:8000/api/v2/validation/plugins
    returns all plugins
  2. http://127.0.0.1:8000/api/v2/validation/plugins?componentType=textfield
    returns all plugins
  3. http://127.0.0.1:8000/api/v2/validation/plugins?component_type=textfield
    returns all plugins

Tasks

  • Fix backend code to adhere to API spec
  • Add query param to frontend code
@CharString CharString added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 13, 2023
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Oct 16, 2023
@joeribekker joeribekker added this to the Release 2.4.0 milestone Oct 16, 2023
@CharString
Copy link
Contributor Author

CharString commented Oct 27, 2023

The getValidatorPlugins js function is passed to the form-builder through a context. I haven't checked how it's called there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants