Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require that events are ordered in time? #107

Open
cdeil opened this issue May 7, 2018 · 1 comment
Open

Require that events are ordered in time? #107

cdeil opened this issue May 7, 2018 · 1 comment
Assignees
Milestone

Comments

@cdeil
Copy link
Member

cdeil commented May 7, 2018

Should we require that IACT DL3 FITS events are ordered in time?

In Gammapy, there's a few things now using event times (e.g. exptest or an adaptive light curve binning method), and we need to either assume they arrive ordered in the DL3 files, or need to sort in those cases on input.

As far as I can see, the GUIDELINES FOR DEFINING FITS FORMATS FOR EVENT LISTS don't require events to be ordered chronologically, they just say this:

The detailed format of a given Event Lists is considered instrument-specific, and the order in which the events are listed application-specific.

@registerrier or anyone - do you know if any missions release EVENTS that are not ordered chronologically?

@woodmd - what does Fermi-LAT do? Are events always ordered chronologically or are files in use where this is not the case?

@jknodlseder - do you assume time ordered in ctools or sort on input if this is needed by some method?

@kosack or @cboisson - are there any thoughts / requirements on this in CTA already?


I would suggest we gather this information here, and everyone says what they prefer, and then we improve the spec to either add the requirement or a comment that time ordering is not required and why cases are allowed where events aren't sorted chronologically.

@cdeil
Copy link
Member Author

cdeil commented Jul 29, 2018

I've added a sentence in #127 that it's recommended to order EVENTs chronologically in DL3 event lists.

@cboisson or @contrera or @kosack or @jknodlseder - Is there a requirement in CTA for DL3 EVENTS that they must be ordered chronologically?

I think that would be very useful.

It's easy to fulfill by DL3 producers, at very low cost. Usually EVENTS will arrive sorted already and processing steps preserve time order. In the rare cases where this is not the case, one can sort once before writing, instead of making all users have to sort on read. Note that as soon as GTIs are used, e.g. for event selection, having a TIME-sorted EVENTS table is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant