-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some files might not respond to ml
#3367
Comments
When you change the method of a type, it is not propagated to child types. This is normal behavior for methods. |
Ah right, that does make sense. This would be resolved by having a proper dependency tree so an |
Wait I think I'm not sure why this works and I can take a look tomorrow. I don't think a dependency tree would actually help since the definition of a child type shouldn't depend on the implementation of a method in the parent. (which is why the original game's |
My thought is if you had a situation like:
It sounds like (and my experience also lines up) that if you are debugging However, if you knew to automatically Though, if it's possible to avoid that, that would be even better. |
I agree with the dependency you said, but I think there's an issue if (this is just my best guess for how goal should work, just based on how their code is organized and how the linker works. if you had TypeB depend on MethodA then you'd have circular references of files) |
I still need to test/verify that this occurs on vanilla but for some reason on the Mod base, when I ML the
vehicle-racer.gc
, then resest actors or even select new game, I do not observe the changes but the ml seems to report that it had worked/doesnt error.I then tested the
ml
on a different file with the same changes and was able to observe the changes instantly. I even loaded a different mission that uses the method to ensure I had a "clean" process and nothing stale and still did not see the change.At the moment the cause of this is unknown so if anyone experiences it with other files, please specify what files/changes below
8mb.video-i7Z-5rZF76sr.mp4
The text was updated successfully, but these errors were encountered: