Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling broken #84

Closed
ChristianKuehnel opened this issue Jan 30, 2018 · 0 comments · Fixed by #85
Closed

Exception handling broken #84

ChristianKuehnel opened this issue Jan 30, 2018 · 0 comments · Fixed by #85
Assignees
@ChristianKuehnel
Labels
bug

Comments

@ChristianKuehnel
Copy link
Collaborator

After investigating home-assistant/core#9048 (comment) I noticed, that the exception handling is broken.

What should happen in case of an exception in the Bluetooth communication:
All exceptions from the different backends are wrapped in BluetoothBackendException.

Current situation:
Each Bluetooth backend raises different types of exceptions, depending on the backend.

This needs to fixed and tested properly
@ChristianKuehnel ChristianKuehnel self-assigned this Jan 30, 2018
This was referenced Jan 30, 2018
Closed
Closed
Merged
giorgioarchi added a commit to mydomo/miflora that referenced this issue Feb 6, 2018
@giorgioarchi
Improvement of exception handling basnijholt#85
624e02b 
ChristianKuehnel
Fixes basnijholt#84

This is a major refactoring of the exception handling in the Bluetooth backends. All errors are now wrapped in BluetootheBackendExceptions, this abstracts from the different exceptions of the different backends.

It also fixes a locking issues when an exception was raised during the connect operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianKuehnel ChristianKuehnel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvement of exception handling ChristianKuehnel/miflora
1 participant
@ChristianKuehnel