Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install script makes assumptions on umask #33

Closed
andreas-ibm opened this issue Feb 3, 2021 · 2 comments
Closed

install script makes assumptions on umask #33

andreas-ibm opened this issue Feb 3, 2021 · 2 comments
Assignees

Comments

@andreas-ibm
Copy link
Contributor

the install script uses cat to create the default config files:

mkdir -p /etc/horizon   # putting the config files here because they are mounted long-term into the containers
cat $TMP_DIR/exchange-tmpl.json | envsubst > /etc/horizon/exchange.json
cat $TMP_DIR/agbot-tmpl.json | envsubst > /etc/horizon/agbot.json
cat $TMP_DIR/css-tmpl.conf | envsubst > /etc/horizon/css.conf

which means that the users umask will determine the permissions.

in my case it meant that they were not world readable, causing the exchange-api and agbot to fail.

I would suggest adding:

chmod a+r /etc/horizon/*

after those lines

@andreas-ibm
Copy link
Contributor Author

Raised PR #34 to fix...

@andreas-ibm
Copy link
Contributor Author

oooh, the PR has been merged, all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant