Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floor orientations for outer wall and window #764

Closed
Mathadon opened this issue Jan 25, 2018 · 1 comment
Closed

Floor orientations for outer wall and window #764

Mathadon opened this issue Jan 25, 2018 · 1 comment
Assignees
@Mathadon
Labels
feature
Milestone
Release 2

Comments

@Mathadon
Copy link
Member

Mathadon commented Jan 25, 2018 •
edited

We currently allow outer walls and windows to have a floor orientation. However, I do not think that the solar irradiation calculations are correct for this orientation. This should be checked and an assert could be added such that this orientation is not allowed. If the computation is correct then it should be added to the list of pre-computed orientations.
@Mathadon Mathadon self-assigned this Jan 25, 2018
@Mathadon Mathadon changed the title Floor orientations for outer wall Floor orientations for outer wall and window Jan 25, 2018
@Mathadon Mathadon added this to the Release 1.1 milestone Jan 26, 2018
@Mathadon Mathadon mentioned this issue Jan 26, 2018
Merged
@Mathadon Mathadon modified the milestones: Release 1.1, Release 1.2 Jun 7, 2018
@Mathadon
Copy link
Member Author

Mathadon commented Jun 7, 2018

fixed in #767

@Mathadon Mathadon closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mathadon Mathadon

Labels
feature
Projects
None yet
Milestone
Release 2
Development

No branches or pull requests
1 participant
@Mathadon