Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of rectangular zone model #880

Closed
damienpicard opened this issue Aug 9, 2018 · 2 comments · Fixed by #884
Closed

Improvement of rectangular zone model #880

damienpicard opened this issue Aug 9, 2018 · 2 comments · Fixed by #884
Milestone

Comments

@damienpicard
Copy link
Contributor

The current implementation of the rectangular zone model allows removing some windows but no walls. This would be a nice added value as the internal wall of a zone can often be lumped which reduces the number of walls to less than 4.

Secondly, when modeling large buildings, it is common to lump several physical rooms into one zone. The internal walls between the rooms need then to be modeled by using an internal wall connected at both sides to the same zone.

I'll try to propose an implementation tackle both shortcomings.

@damienpicard damienpicard added this to the Release 2 milestone Aug 9, 2018
@Mathadon
Copy link
Member

Mathadon commented Aug 9, 2018

@damienpicard best to split this into two separate issues to avoid delaying merging one if we cannot find a satisfactory solution for the other?

@damienpicard
Copy link
Contributor Author

@Mathadon ok, I'll make another issue for the internal wall model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants