Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myLibrary/myCourses: New tab conflict #6984

Open
jsschf opened this issue Jul 30, 2020 · 2 comments
Open

myLibrary/myCourses: New tab conflict #6984

jsschf opened this issue Jul 30, 2020 · 2 comments

Comments

@jsschf
Copy link
Member

jsschf commented Jul 30, 2020

Steps to reproduce

  1. In Enterprises, click "Add documents"
  2. When the dialog opens, click on the name of a document. A new tab should open
  3. In the new tab, click "Add to myLibrary"
  4. Close the new tab, navigate to myDashboard
  5. Trying to delete any courses from myLibrary causes two console errors

https://www.loom.com/share/d9d1865c821a40c69cfe79ab76ac12a2

Annotation 2020-07-30 090835
Annotation 2020-07-30 090920

@paulbert paulbert changed the title Enterprises: Add document error myLibrary/myCourses: New tab conflict Jul 30, 2020
@paulbert
Copy link
Member

The problem is that the new information for the dashboard is not loaded in the old tab. It's not limited to Enterprises or the Dashboard. If two tabs are opened and the myLibrary or myCourses items are changed in one, trying to change them in the other will fail.

Looks like there is no error message shown to the user, either.

I think we want to show an error with a "Please try again" and reload the information from the shelf database.

@paulbert
Copy link
Member

Note this is most likely to happen in real use by taking the steps above, but simply opening a second tab in your browser is the easiest way to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants