Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prompt=login optional for OIDC Login #16062

Open
mgorsk1 opened this issue Apr 26, 2024 · 0 comments
Open

Make prompt=login optional for OIDC Login #16062

mgorsk1 opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
backend enhancement New feature or request

Comments

@mgorsk1
Copy link
Contributor

mgorsk1 commented Apr 26, 2024

Is your feature request related to a problem? Please describe.

With current OIDC implementation, prompt=login parameter passed to OIDC provider is enforced. In some cases there is no need to make users fill login form - especially when OM is one of many OIDC configured services users rely on, in which case ideally they would be logged in without filling out form again (assuming proper token is stored in cookies).

Describe the solution you'd like
I think better fit for configuring such flow would be to leave it to the deployment admin of OM - admin would decide whether we need this or not and client.getConfiguration().getCustomParams() is where such parameter could be passed.

Describe alternatives you've considered
Currently in our build of OM we just remove lines hardcoding this parameter in request.

Additional context
https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-service/src/m[…]in/java/org/openmetadata/service/security/AuthLoginServlet.java

@mgorsk1 mgorsk1 added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants