Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError - Numpy - Ingestion #2980

Closed
ayush-shah opened this issue Feb 24, 2022 · 1 comment · Fixed by #2982
Closed

ImportError - Numpy - Ingestion #2980

ayush-shah opened this issue Feb 24, 2022 · 1 comment · Fixed by #2982
Assignees
Labels
bug Something isn't working Ingestion

Comments

@ayush-shah
Copy link
Member

Affected module
Does it impact the UI, backend or Ingestion Framework?
Ingestion

Describe the bug
A clear and concise description of what the bug is.
Numpy Dependency added in histogram.py(orm profiler) causes the sample_data ingestion to fail.

To Reproduce
Create new env
Install dependencies and generate new models
Ingest Sample Data

If numpy is not being used anywhere, we can remove the dependency.
if it's being used somewhere, we can add it in base requirements or create a new plugin
cc: @pmbrull @harshach

@ayush-shah ayush-shah added bug Something isn't working Ingestion labels Feb 24, 2022
@ayush-shah ayush-shah added this to To do in Release 0.9.0 via automation Feb 24, 2022
@pmbrull
Copy link
Collaborator

pmbrull commented Feb 24, 2022

Thanks @ayush-shah , added it already in the PR I am working on

Release 0.9.0 automation moved this from To do to Done Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ingestion
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants