New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium tests issue fix #3010

Merged

darth-coder00 merged 33 commits into open-metadata:main from kshinde2512:Fixing-selenium-issue

Mar 4, 2022

Contributor

kshinde2512 commented Feb 28, 2022

Describe your changes :

I worked on the Fixing selenium issues

Type of change :

Improvement

Checklist:

I have read the CONTRIBUTING document.
I have performed a self-review of my own.
I have tagged my reviewers below.
I have commented on my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
All new and existing tests passed.

Reviewers

@darth-coder00 @shahsank3t @parthp2107


          Minor Tweaks

6d24662

github-actions bot commented Feb 28, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Ingestion fail changes

84947c4

github-actions bot commented Feb 28, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kushal added 2 commits

February 28, 2022 21:26


          Merge branch 'main' into Fixing-selenium-issue

b2ffe50


          Adding Entity details page fix and no ingestion page fix

83f4966

github-actions bot commented Mar 1, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kushal added 6 commits

March 1, 2022 10:28


          Java checkstyle

8f1387b


          Merge branch 'main' into Fixing-selenium-issue

c9766b1


          Selenium fixes

a347bbc


          Minor code change

cb7bab3


          Adding implicit wait

6de4c28


          minor code change

56a145e

github-actions bot commented Mar 1, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kushal added 5 commits

March 1, 2022 14:54


          Java checkstyle

ff3ae6e


          Merge branch 'main' into Fixing-selenium-issue

3d9257b


          Locator change

753f6f7


          minor code change

248d9b3


          Minor code change

4c21782

github-actions bot commented Mar 1, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kushal added 3 commits

March 1, 2022 23:40


          Java checkstyle

8a3b8d5


          minor code change

64d141e


          Merge branch 'main' into Fixing-selenium-issue

68a7f8c

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kshinde2512 mentioned this pull request

Minor code changes #2983

Closed

8 tasks


          Merge branch 'main' into Fixing-selenium-issue

79f05ae

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Merge branch 'main' into Fixing-selenium-issue

cdb6355

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Changed assertions and locators

6487c85

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Locator changes

3f4ff23

github-actions bot commented Mar 2, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Fixing tests in Entity details page

1dd4a74

github-actions bot commented Mar 2, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kshinde2512 changed the title ~~Minor Tweaks~~ Selenium tests issue fix

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Javacheckstyle for entity details page

5574b79

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Fixing Dashboard details issue

b94a98a

github-actions bot commented Mar 2, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Java checkstyle

5d6ecc2

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Adding options

63d73d9

github-actions bot commented Mar 2, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Merge branch 'main' into Fixing-selenium-issue

b35b167

github-actions bot commented Mar 3, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          Locator fixes

ed572d6

github-actions bot commented Mar 3, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions bot commented Mar 3, 2022

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

kushal added 2 commits

March 3, 2022 14:05


          Java and Python checkstyle

a837087


          test fix

80330ee

sonarcloud bot commented Mar 3, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information


          Update setup.py

92c3716

sonarcloud bot commented Mar 3, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
44 Code Smells

No Coverage information
0.0% Duplication

parthp2107 approved these changes

View reviewed changes

darth-coder00 approved these changes

View reviewed changes

darth-coder00 merged commit 24ef2af into open-metadata:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment