Feat: Add freshness + rows inserted graphs on the UI side#9117 #9203

ShaileshParmar11 · 2022-12-07T15:26:28Z

Describe your changes :

Add freshness + rows inserted graphs on the UI side#9117
Closes #9117

Type of change :

New feature

Frontend Preview (Screenshots) :

Screen.Recording.2022-12-14.at.6.49.24.PM.mov

Checklist:

I have read the CONTRIBUTING document.
I have commented on my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
All new and existing tests passed.

Reviewers

cypress · 2022-12-07T16:25:46Z

Test summary

183 • 1 • 3 • 0

Run details


Project	openmetadata
Status	Failed
Commit	`e1495d7`
Started	Dec 14, 2022 1:14 PM
Ended	Dec 14, 2022 1:53 PM
Duration	39:30 💡
OS	Linux Ubuntu - 22.04
Browser	Multiple

View run in Cypress Dashboard ➡️

Failures

	cypress/e2e/Pages/redirections.spec.js		1
1	Redirection link should work properly > Check mydata redirection links on navbar

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

sonarcloud · 2022-12-14T13:11:41Z

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

60.3% Coverage
0.0% Duplication

sonarcloud · 2022-12-14T13:13:40Z

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud · 2022-12-14T14:04:22Z

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
30 Code Smells

22.3% Coverage
1.8% Duplication

chirag-madlani · 2022-12-14T14:24:51Z

openmetadata-ui/src/main/resources/ui/src/components/Chart/OperationDateBarChart.tsx

+        {information.map((info) => (
+          <Bar
+            barSize={1}
+            dataKey={info.dataKey}
+            fill={info.color}
+            hide={
+              activeKeys.length ? !activeKeys.includes(info.dataKey) : false
+            }
+            key={`${info.dataKey}-bar`}
+            name={info.title}
+            stackId="data"
+          />
+        ))}
+        {information.map((info) => (
+          <Scatter
+            dataKey={info.dataKey}
+            fill={info.color}
+            hide={
+              activeKeys.length ? !activeKeys.includes(info.dataKey) : false
+            }
+            key={`${info.dataKey}-scatter`}
+            name={info.title}
+          />
+        ))}


I feel now we can combine this to single loop but we can do that on next PR as well

Yes will do in next PR thanks

…metadata#9203) * Updated common background to seprate component background * move tab in to left panel for profiler tab * added table profiler component * added system profiler api * Added row metrics * Added operation date metricsa chart * added localization support for the table profiler * added timerange filer for profiler * fixed failing test * added unit test for new component * fixed failing cypress * fixed cypress for DBT * Address the comments * fixed failing cypress * seprated mock file for rechart * addressing comments * addressing comments * added scatter chart, updated tab order * added lolipop chart * added filter for chart legend * fixed failing unit test * added mock component * fixing failing cypress * fixed cypress

* Updated common background to seprate component background * move tab in to left panel for profiler tab * added table profiler component * added system profiler api * Added row metrics * Added operation date metricsa chart * added localization support for the table profiler * added timerange filer for profiler * fixed failing test * added unit test for new component * fixed failing cypress * fixed cypress for DBT * Address the comments * fixed failing cypress * seprated mock file for rechart * addressing comments * addressing comments * added scatter chart, updated tab order * added lolipop chart * added filter for chart legend * fixed failing unit test * added mock component * fixing failing cypress * fixed cypress

Updated common background to seprate component background

ce5929c

ShaileshParmar11 temporarily deployed to cypress December 7, 2022 15:26 — with GitHub Actions Inactive

github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Dec 7, 2022

ShaileshParmar11 added 2 commits December 8, 2022 17:37

Merge remote-tracking branch 'origin/main' into table-profiler-metrics

47d1c84

move tab in to left panel for profiler tab

a2fbfe4

ShaileshParmar11 temporarily deployed to cypress December 8, 2022 14:24 — with GitHub Actions Inactive

ShaileshParmar11 added 2 commits December 9, 2022 09:55

Merge remote-tracking branch 'origin/main' into table-profiler-metrics

0ec5886

added table profiler component

1658443

ShaileshParmar11 temporarily deployed to cypress December 9, 2022 05:16 — with GitHub Actions Inactive

added system profiler api

c37b007

ShaileshParmar11 temporarily deployed to cypress December 9, 2022 08:53 — with GitHub Actions Inactive

Added row metrics

663d278

ShaileshParmar11 temporarily deployed to cypress December 9, 2022 10:23 — with GitHub Actions Inactive

ShaileshParmar11 temporarily deployed to cypress December 14, 2022 11:06 — with GitHub Actions Inactive

added mock component

0a1dd96

ShaileshParmar11 temporarily deployed to cypress December 14, 2022 11:18 — with GitHub Actions Inactive

ShaileshParmar11 added 2 commits December 14, 2022 17:39

fixing failing cypress

9fab61c

Merge remote-tracking branch 'origin/main' into table-profiler-metrics

3a1798e

ShaileshParmar11 temporarily deployed to cypress December 14, 2022 12:13 — with GitHub Actions Inactive

ShaileshParmar11 temporarily deployed to cypress December 14, 2022 12:18 — with GitHub Actions Inactive

fixed cypress

e1495d7

ShaileshParmar11 temporarily deployed to cypress December 14, 2022 12:52 — with GitHub Actions Inactive

ShaileshParmar11 requested review from chirag-madlani and Sachin-chaurasiya December 14, 2022 13:24

chirag-madlani approved these changes Dec 14, 2022

View reviewed changes

ShaileshParmar11 merged commit c365446 into main Dec 14, 2022

ShaileshParmar11 deleted the table-profiler-metrics branch December 14, 2022 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Add freshness + rows inserted graphs on the UI side#9117 #9203

Feat: Add freshness + rows inserted graphs on the UI side#9117 #9203

ShaileshParmar11 commented Dec 7, 2022 •

edited

cypress bot commented Dec 7, 2022 •

edited

sonarcloud bot commented Dec 14, 2022

sonarcloud bot commented Dec 14, 2022

sonarcloud bot commented Dec 14, 2022

chirag-madlani Dec 14, 2022

ShaileshParmar11 Dec 14, 2022

Feat: Add freshness + rows inserted graphs on the UI side#9117 #9203

Feat: Add freshness + rows inserted graphs on the UI side#9117 #9203

Conversation

ShaileshParmar11 commented Dec 7, 2022 • edited

Describe your changes :

Type of change :

Frontend Preview (Screenshots) :

Checklist:

Reviewers

cypress bot commented Dec 7, 2022 • edited

Test summary

Run details

Failures

sonarcloud bot commented Dec 14, 2022

sonarcloud bot commented Dec 14, 2022

sonarcloud bot commented Dec 14, 2022

chirag-madlani Dec 14, 2022

Choose a reason for hiding this comment

ShaileshParmar11 Dec 14, 2022

Choose a reason for hiding this comment

ShaileshParmar11 commented Dec 7, 2022 •

edited

cypress bot commented Dec 7, 2022 •

edited