Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to return if the logged in user owns a dataset or not #74

Closed
sureshms opened this issue Aug 9, 2021 · 3 comments
Closed

API to return if the logged in user owns a dataset or not #74

sureshms opened this issue Aug 9, 2021 · 3 comments
Assignees

Comments

@sureshms
Copy link
Contributor

sureshms commented Aug 9, 2021

If the API requesting table information is passing a field like "owners". We should return owners filed as we do today and include "ownedByMe" in extra fields.

  1. If the logged-in user is owned dataset returns true
  2. if the team is owned and logged in user belongs to the tam return true
  3. for all other cases we should return false.
@sureshms sureshms self-assigned this Aug 9, 2021
@sureshms
Copy link
Contributor Author

sureshms commented Aug 9, 2021

There is already a field called "owns" in the user. Have you tried that?

@sureshms
Copy link
Contributor Author

sureshms commented Aug 9, 2021

Based on our discussion, we wanted to disable any edit controls if the logged-in user is not the owner and enable them only if they are the owner. We can use api/v1/users?fields=owns but UI has to do the comparison then only display the controls.

API

curl -XGET /api/v1/table/{id}|{name}?fields=owns

Response

{
  "id": "f937ee0d-fe29-4cd1-ae0b-9b6c056f23b6",
  "name": "sql_features",
  "href": "http://localhost:8585/api/v1/tables/f937ee0d-fe29-4cd1-ae0b-9b6c056f23b6",
  "fullyQualifiedName": "aws_redshift.information_schema.sql_features",
  "ownedByLoggedinUser": "true|false"
}

gitbook-com bot pushed a commit that referenced this issue Dec 11, 2021
parthp2107 pushed a commit that referenced this issue Dec 13, 2021
shahsank3t pushed a commit that referenced this issue Dec 13, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
parthp2107 added a commit that referenced this issue Dec 13, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
omriAl pushed a commit to omriAl/OpenMetadata that referenced this issue Dec 14, 2021
* GitBook: [open-metadata#70] Update to Roadmap

* GitBook: [open-metadata#72] Modified Looker and Oracle Connector

* GitBook: [open-metadata#71] Change Events

* GitBook: [open-metadata#74] API Component

* GitBook: [open-metadata#73] MlFlow Connector

* GitBook: [open-metadata#75] PUT Diagram

* GitBook: [open-metadata#76] Change Events

* GitBook: [open-metadata#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
harshach pushed a commit that referenced this issue Dec 15, 2021
* GitBook: [#70] Update to Roadmap

* GitBook: [#72] Modified Looker and Oracle Connector

* GitBook: [#71] Change Events

* GitBook: [#74] API Component

* GitBook: [#73] MlFlow Connector

* GitBook: [#75] PUT Diagram

* GitBook: [#76] Change Events

* GitBook: [#77] Snowflake Single Sign-on changes

Co-authored-by: OpenMetadata <github@harsha.io>
Co-authored-by: Ayush Shah <ayush.shah@deuexsolutions.com>
Co-authored-by: pmbrull <peremiquelbrull@gmail.com>
@sureshms
Copy link
Contributor Author

sureshms commented Jan 5, 2022

No longer relevant

@sureshms sureshms closed this as completed Jan 5, 2022
gitbook-com bot pushed a commit that referenced this issue Jan 6, 2022
parthp2107 pushed a commit that referenced this issue Jan 20, 2022
harshach pushed a commit that referenced this issue Jan 20, 2022
codingwithabhi pushed a commit to codingwithabhi/OpenMetadata that referenced this issue Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant