Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] prompt the built version of mmcv-full #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Feat] prompt the built version of mmcv-full #150

wants to merge 1 commit into from

Conversation

ice-tong
Copy link
Collaborator

@ice-tong ice-tong commented Jul 6, 2022 •
edited

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Get and prompt the built version of mmcv-full that satisfies the current environment. close #149

Modification

  • commands/install.py
  • utlis/utils.py
  • utils/__init__.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

image

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ice-tong ice-tong requested a review from zhouzaida July 6, 2022 04:15
@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited

Codecov Report

Merging #150 (9b369e7) into main (eb5c5c6) will increase coverage by 21.88%.
The diff coverage is 69.33%.

@@             Coverage Diff             @@
##             main     #150       +/-   ##
===========================================
+ Coverage   32.58%   54.46%   +21.88%     
===========================================
  Files          21       23        +2     
  Lines        1593     1568       -25     
  Branches      363      333       -30     
===========================================
+ Hits          519      854      +335     
+ Misses       1032      587      -445     
- Partials       42      127       +85
Flag Coverage Δ
unittests 54.46% <69.33%> (+21.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mim/utils/default.py 84.61% <ø> (ø)
mim/version.py 0.00% <0.00%> (ø)
mim/click/compat.py 45.45% <45.45%> (ø)
mim/click/option.py 54.05% <50.00%> (+23.75%) ⬆️
mim/commands/install.py 70.12% <68.70%> (+1.48%) ⬆️
mim/commands/uninstall.py 76.19% <76.47%> (-16.12%) ⬇️
mim/utils/utils.py 68.75% <76.47%> (+17.93%) ⬆️
mim/click/__init__.py 100.00% <100.00%> (ø)
mim/commands/download.py 88.46% <100.00%> (+53.84%) ⬆️
mim/commands/search.py 54.00% <100.00%> (+41.24%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c869f73...9b369e7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida Awaiting requested review from zhouzaida

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mim install should prompt the supported built version of mmcv-full
1 participant
@ice-tong