New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix the punctuation display problem and the path separator problem on Windows #166
Conversation
Hi @RangeKing , thanks for your kind contribution~ I haven't reproduced this display problem in both CMD and Powershell. |
@ice-tong It also occurs in CMD which uses a different font from Powershell. Here's my env info:
|
Hi @RangeKing, thanks for the information~ I have not successfully reproduced this problem, but I believe it is an enhancement that does not affect compatibility. This change looks great to me, and you should rebase the main branch to fix the pre-commit error in CI. ^_^ |
Hi @RangeKing , the rebase seems not successful. Maybe the following steps work: git add remote mim https://github.com/open-mmlab/mim.git
git pull mim main:main
git rebase main
git push -f origin fix_typo:fix_typo |
@ice-tong Thank you for your patient guidance. The rebase had been successful. |
Codecov ReportBase: 56.62% // Head: 56.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 56.62% 56.62%
=======================================
Files 24 24
Lines 1584 1584
Branches 334 334
=======================================
Hits 897 897
Misses 549 549
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
1.Fix the punctuation display problem on Windows, when running the command
mim run mmdet -h
.2.Fix the path separator problem on Windows, when running the command
mim run mmdet -h
.Modification
Replace all
Don’t
->Don\'t
for problem 1.In
mim/click/customcommand.py
, '/' -> os.sep for problem 2.