Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the punctuation display problem and the path separator problem on Windows #166

Merged
merged 2 commits into from Oct 21, 2022

Conversation

RangeKing
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

1666087934605
1.Fix the punctuation display problem on Windows, when running the command mim run mmdet -h.

10615f6753552529333432d391461b5
2.Fix the path separator problem on Windows, when running the command mim run mmdet -h.

Modification

Replace all Don’t -> Don\'t for problem 1.
In mim/click/customcommand.py, '/' -> os.sep for problem 2.

@ice-tong
Copy link
Collaborator

ice-tong commented Oct 18, 2022

Hi @RangeKing , thanks for your kind contribution~

I haven't reproduced this display problem in both CMD and Powershell.
Can you provide more information to help me reproduce this problem? ^_^
image

@RangeKing
Copy link
Contributor Author

RangeKing commented Oct 18, 2022

image

@ice-tong It also occurs in CMD which uses a different font from Powershell.

Here's my env info:

Windows 10 教育版
21H2
19044.2130
Name: openmim
Version: 0.3.2
sys.platform: win32
Python: 3.8.13 (default, Mar 28 2022, 06:59:08) [MSC v.1916 64 bit (AMD64)]
CUDA available: True
numpy_random_seed: 2147483648
GPU 0: NVIDIA GeForce RTX 2070
CUDA_HOME: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1
NVCC: Cuda compilation tools, release 10.1, V10.1.16
GCC: n/a
PyTorch: 1.8.1+cu101
PyTorch compiling details: PyTorch built with:
  - C++ Version: 199711
  - MSVC 192829913
  - Intel(R) Math Kernel Library Version 2020.0.2 Product Build 20200624 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v1.7.0 (Git Hash 7aed236906b1f7a05c0917e5257a1af05e9ff683)
  - OpenMP 2019
  - CPU capability usage: AVX2
  - CUDA Runtime 10.1
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_37,code=compute_37
  - CuDNN 7.6.4
  - Magma 2.5.4
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=10.1, CUDNN_VERSION=7.6.4, CXX_COMPILER=C:/w/b/windows/tmp_bin/sccache-cl.exe, CXX_FLAGS=/DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -DNDEBUG -DUSE_FBGEMM -DUSE_XNNPACK, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.8.1, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, 
USE_MPI=OFF, USE_NCCL=OFF, USE_NNPACK=OFF, USE_OPENMP=ON,

TorchVision: 0.9.1+cu101
OpenCV: 4.6.0
MMEngine: 0.2.0
MMCV: 2.0.0rc1
MMDetection: 3.0.0rc1
MMYOLO: 0.1.1+5153d05

@ice-tong
Copy link
Collaborator

ice-tong commented Oct 19, 2022

Hi @RangeKing, thanks for the information~

I have not successfully reproduced this problem, but I believe it is an enhancement that does not affect compatibility.

This change looks great to me, and you should rebase the main branch to fix the pre-commit error in CI. ^_^

@ice-tong
Copy link
Collaborator

Hi @RangeKing , the rebase seems not successful.

image

Maybe the following steps work:

git add remote mim https://github.com/open-mmlab/mim.git
git pull mim main:main
git rebase main
git push -f origin fix_typo:fix_typo

@RangeKing
Copy link
Contributor Author

@ice-tong Thank you for your patient guidance. The rebase had been successful.
image

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 56.62% // Head: 56.62% // No change to project coverage 👍

Coverage data is based on head (d6eaf18) compared to base (66ba337).
Patch coverage: 80.00% of modified lines in pull request are covered.

❗ Current head d6eaf18 differs from pull request most recent head f1b97df. Consider uploading reports for the commit f1b97df to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   56.62%   56.62%           
=======================================
  Files          24       24           
  Lines        1584     1584           
  Branches      334      334           
=======================================
  Hits          897      897           
  Misses        549      549           
  Partials      138      138           
Flag Coverage Δ
unittests 56.62% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mim/click/customcommand.py 27.27% <0.00%> (ø)
mim/commands/uninstall.py 76.19% <ø> (ø)
mim/commands/gridsearch.py 51.41% <100.00%> (ø)
mim/commands/run.py 49.31% <100.00%> (ø)
mim/commands/test.py 43.56% <100.00%> (ø)
mim/commands/train.py 44.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit 55557c8 into open-mmlab:main Oct 21, 2022
@RangeKing RangeKing deleted the fix-typo branch November 6, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants