You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"""Format final imgs shape to the given input_format.
Required keys:
However, the context and function of these two are distinctly different. The Transforms.FormatShape is aptly named as it actively formats the shape of data. In contrast, ActionDataPreprocessor.format_shape is essentially a descriptor indicating the required shape format (i.e., 'NCHW') for the data to be correctly processed by the preprocessor.
What is the feature?
(Option 1) A more descriptive name than ActionDataPreprocessor.format_shape, such as expected_shape_format or shape_format might better convey its purpose and reduce potential confusion.
(Option 2) Deprecating the Transform.FormatShape and making the ActionDataPreprocessor do the shape formatting job.
What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered:
What is the problem this feature will solve?
The argument name
format_shape
inActionDataPreprocessor
can be misleading:mmaction2/mmaction/models/data_preprocessors/data_preprocessor.py
Lines 30 to 37 in 4d6c934
This name is identical to
Transforms.FormatShape
:mmaction2/mmaction/datasets/transforms/formatting.py
Lines 200 to 204 in 4d6c934
However, the context and function of these two are distinctly different. The
Transforms.FormatShape
is aptly named as it actively formats the shape of data. In contrast,ActionDataPreprocessor.format_shape
is essentially a descriptor indicating the required shape format (i.e., 'NCHW') for the data to be correctly processed by the preprocessor.What is the feature?
ActionDataPreprocessor.format_shape
, such asexpected_shape_format
orshape_format
might better convey its purpose and reduce potential confusion.Transform.FormatShape
and making theActionDataPreprocessor
do the shape formatting job.What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered: