Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why we do not need to use DistributedDataParallel for netF? #47

Closed
rakhimovv opened this issue Jan 22, 2020 · 2 comments
Closed

Why we do not need to use DistributedDataParallel for netF? #47

rakhimovv opened this issue Jan 22, 2020 · 2 comments

Comments

@rakhimovv
Copy link

Thanks for the great project. Looking through code, I noticed that in SRGAN_model.py there are such lines:

if opt['dist']:
    pass  # do not need to use DistributedDataParallel for netF
else:
    self.netF = DataParallel(self.netF)

can you please provide motivation of not wrapping netF with DistributedDataParallel

@xinntao
Copy link
Collaborator

xinntao commented Feb 8, 2020

Because there is no need to update netF during training.
If we use DistributedDataParallel for netF and we do not update netF, then errors will be raised.

@rakhimovv
Copy link
Author

Thanks for the answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants