Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add mixmim backbone with inference #1224

Merged
merged 60 commits into from Dec 20, 2022
Merged

[Feature] Add mixmim backbone with inference #1224

merged 60 commits into from Dec 20, 2022

Conversation

wangbo-zhao
Copy link
Contributor

@wangbo-zhao wangbo-zhao commented Nov 24, 2022

MMselfSelf want to support "MixMIM: Mixed and Masked Image Modeling for Efficient Visual Representation Learning". We hope mmcls can support the backbone proposed in it. This PR has aligned the inference precision.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

configs/mixmim/README.md Outdated Show resolved Hide resolved
configs/mixmim/README.md Outdated Show resolved Hide resolved
configs/mixmim/metafile.yml Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
@wangbo-zhao wangbo-zhao requested review from fangyixiao18 and removed request for YuanLiuuuuuu December 6, 2022 06:14
configs/mixmim/README.md Outdated Show resolved Hide resolved
configs/mixmim/metafile.yml Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
tests/test_models/test_backbones/test_mixmim.py Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
configs/mixmim/metafile.yml Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
configs/mixmim/metafile.yml Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
mmcls/models/backbones/mixmim.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fangyixiao18 fangyixiao18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 0.02% // Head: 88.62% // Increases project coverage by +88.60% 🎉

Coverage data is based on head (c264fc2) compared to base (b8b31e9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1224       +/-   ##
============================================
+ Coverage     0.02%   88.62%   +88.60%     
============================================
  Files          121      153       +32     
  Lines         8217    12275     +4058     
  Branches      1368     1944      +576     
============================================
+ Hits             2    10879    +10877     
+ Misses        8215     1080     -7135     
- Partials         0      316      +316     
Flag Coverage Δ
unittests 88.62% <ø> (+88.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/transforms/compose.py
mmcls/models/backbones/replknet.py 93.00% <0.00%> (ø)
mmcls/engine/hooks/ema_hook.py 81.69% <0.00%> (ø)
mmcls/models/heads/multi_label_csra_head.py 40.54% <0.00%> (ø)
mmcls/models/classifiers/hugging_face.py 25.64% <0.00%> (ø)
mmcls/models/backbones/hornet.py 82.05% <0.00%> (ø)
mmcls/models/heads/efficientformer_head.py 93.10% <0.00%> (ø)
mmcls/models/retrievers/base.py 100.00% <0.00%> (ø)
mmcls/models/necks/reduction.py 100.00% <0.00%> (ø)
mmcls/models/backbones/davit.py 84.94% <0.00%> (ø)
... and 144 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mzr1996 mzr1996 merged commit 14dcb69 into open-mmlab:dev-1.x Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants