Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Avoid installing both opencv and opencv-headless. #397

Merged
merged 1 commit into from Aug 9, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Aug 9, 2021

Motivation

Our optional dependency albumentations may install both opencv and opencv-headless. Refers to the docs.

Modification

This PR updates the installation of albumentations to prevent using a wheel distribution of it with opencv-headless dependency. Refers to open-mmlab/mmpose#833

BC-breaking (Optional)

No

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu August 9, 2021 02:08
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #397 (d7e6197) into master (a747458) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head d7e6197 differs from pull request most recent head ba7717c. Consider uploading reports for the commit ba7717c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   76.51%   76.54%   +0.02%     
==========================================
  Files          97       97              
  Lines        5224     5222       -2     
  Branches      856      855       -1     
==========================================
  Hits         3997     3997              
+ Misses       1108     1106       -2     
  Partials      119      119              
Flag Coverage Δ
unittests 76.54% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/imagenet.py 25.53% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a747458...ba7717c. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit e4188c8 into open-mmlab:master Aug 9, 2021
@mzr1996 mzr1996 deleted the albu-dep branch August 13, 2021 09:51
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants