Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Rename config files according to the config name standard. #508

Merged
merged 8 commits into from
Nov 19, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Nov 2, 2021

Motivation

We have come up with a config filename convention, but many config files don't use this convention.
To make the filenames more clear, change these config names.

Modification

Like the title
The comparison table:

old new
resnet50_b32x8_fp16_dynamic_imagenet.py resnet50_8xb32-fp16-dynamic_in1k.py
resnet50_b32x8_fp16_imagenet.py resnet50_8xb32-fp16_in1k.py
mobilenet_v2_b32x8_imagenet.py mobilenet-v2_8xb32_in1k.py
mobilenet_v3_large_imagenet.py mobilenet-v3-large_8xb32_in1k.py
mobilenet_v3_small_cifar.py mobilenet-v3-small_8xb16_cifar.py
mobilenet_v3_small_imagenet.py mobilenet-v3-small_8xb32_in1k.py
regnetx_1.6gf_b32x8_imagenet.py regnetx-1.6gf_8xb32_in1k.py
regnetx_12gf_b32x8_imagenet.py regnetx-12gf_8xb32_in1k.py
regnetx_3.2gf_b32x8_imagenet.py regnetx-3.2gf_8xb32_in1k.py
regnetx_4.0gf_b32x8_imagenet.py regnetx-4.0gf_8xb32_in1k.py
regnetx_400mf_b32x8_imagenet.py regnetx-400mf_8xb32_in1k.py
regnetx_6.4gf_b32x8_imagenet.py regnetx-6.4gf_8xb32_in1k.py
regnetx_8.0gf_b32x8_imagenet.py regnetx-8.0gf_8xb32_in1k.py
regnetx_800mf_b32x8_imagenet.py regnetx-800mf_8xb32_in1k.py
resnest101_b64x32_imagenet.py resnest101_32xb64_in1k.py
resnest200_b32x64_imagenet.py resnest200_64xb32_in1k.py
resnest269_b32x64_imagenet.py resnest269_64xb32_in1k.py
resnest50_b64x32_imagenet.py resnest50_32xb64_in1k.py
resnet101_b16x8_cifar10.py resnet101_8xb16_cifar10.py
resnet101_b32x8_imagenet.py resnet101_8xb32_in1k.py
resnet152_b16x8_cifar10.py resnet152_8xb16_cifar10.py
resnet152_b32x8_imagenet.py resnet152_8xb32_in1k.py
resnet18_b16x8_cifar10.py resnet18_8xb16_cifar10.py
resnet18_b32x8_imagenet.py resnet18_8xb32_in1k.py
resnet34_b16x8_cifar10.py resnet34_8xb16_cifar10.py
resnet34_b32x8_imagenet.py resnet34_8xb32_in1k.py
resnet50_b16x8_cifar10.py resnet50_8xb16_cifar10.py
resnet50_b16x8_cifar100.py resnet50_8xb16_cifar100.py
resnet50_b16x8_cifar10_mixup.py resnet50_8xb16-mixup_cifar10.py
resnet50_b32x8_coslr_imagenet.py resnet50_8xb32-coslr_in1k.py
resnet50_b32x8_cutmix_imagenet.py resnet50_8xb32-cutmix_in1k.py
resnet50_b32x8_imagenet.py resnet50_8xb32_in1k.py
resnet50_b32x8_label_smooth_imagenet.py resnet50_8xb32-lbs_in1k.py
resnet50_b32x8_mixup_imagenet.py resnet50_8xb32-mixup_in1k.py
resnet50_b64x32_warmup_coslr_imagenet.py resnet50_32xb64-warmup-coslr_in1k.py
resnet50_b64x32_warmup_imagenet.py resnet50_32xb64-warmup_in1k.py
resnet50_b64x32_warmup_label_smooth_imagenet.py resnet50_32xb64-warmup-lbs_in1k.py
resnetv1d101_b32x8_imagenet.py resnetv1d101_8xb32_in1k.py
resnetv1d152_b32x8_imagenet.py resnetv1d152_8xb32_in1k.py
resnetv1d50_b32x8_imagenet.py resnetv1d50_8xb32_in1k.py
resnext101_32x4d_b32x8_imagenet.py resnext101-32x4d_8xb32_in1k.py
resnext101_32x8d_b32x8_imagenet.py resnext101-32x8d_8xb32_in1k.py
resnext152_32x4d_b32x8_imagenet.py resnext152-32x4d_8xb32_in1k.py
resnext50_32x4d_b32x8_imagenet.py resnext50-32x4d_8xb32_in1k.py
seresnet101_b32x8_imagenet.py seresnet101_8xb32_in1k.py
seresnet50_b32x8_imagenet.py seresnet50_8xb32_in1k.py
seresnext101_32x4d_b32x8_imagenet.py seresnext101-32x4d_8xb32_in1k.py
seresnext50_32x4d_b32x8_imagenet.py seresnext50-32x4d_8xb32_in1k.py
shufflenet_v1_1x_b64x16_linearlr_bn_nowd_imagenet.py shufflenet-v1-1x_16xb64_in1k.py
shufflenet_v2_1x_b64x16_linearlr_bn_nowd_imagenet.py shufflenet-v2-1x_16xb64_in1k.py
swin_large_224_evalonly_imagenet.py swin-large_16xb64_in1k.py
swin_large_384_evalonly_imagenet.py swin-large_16xb64_in1k-384px.py
swin_small_224_b16x64_300e_imagenet.py swin-small_16xb64_in1k.py
swin_tiny_224_b16x64_300e_imagenet.py swin-tiny_16xb64_in1k.py
tnt_s_patch16_224_evalonly_imagenet.py tnt-s-p16_16xb64_in1k.py
vgg11_b32x8_imagenet.py vgg11_8xb32_in1k.py
vgg11bn_b32x8_imagenet.py vgg11bn_8xb32_in1k.py
vgg13_b32x8_imagenet.py vgg13_8xb32_in1k.py
vgg13bn_b32x8_imagenet.py vgg13bn_8xb32_in1k.py
vgg16_b16x8_voc.py vgg16_8xb16_voc.py
vgg16_b32x8_imagenet.py vgg16_8xb32_in1k.py
vgg16bn_b32x8_imagenet.py vgg16bn_8xb32_in1k.py
vgg19_b32x8_imagenet.py vgg19_8xb32_in1k.py
vgg19bn_b32x8_imagenet.py vgg19bn_8xb32_in1k.py

BC-breaking (Optional)

No, we keep all original config files and add a deprecation warning.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 added the WIP label Nov 2, 2021
@mzr1996 mzr1996 marked this pull request as ready for review November 2, 2021 07:00
@mzr1996 mzr1996 requested a review from Ezra-Yu November 2, 2021 07:00
@mzr1996 mzr1996 removed the WIP label Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #508 (04ba776) into master (9f31fc5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files         107      107           
  Lines        6093     6093           
  Branches      987      987           
=======================================
  Hits         4867     4867           
  Misses       1094     1094           
  Partials      132      132           
Flag Coverage Δ
unittests 79.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f31fc5...04ba776. Read the comment docs.

@mzr1996 mzr1996 force-pushed the config-rename branch 2 times, most recently from 55659b8 to 244460a Compare November 2, 2021 08:00
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. some configs such as 1, 2, please check.

  2. It seems that all configuration file names are lowercase, then the repvgg configs should be modified to lowercase too and some trick info should remove from config names.

@@ -0,0 +1,8 @@
_base_ = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be mobilenet-v3-small_8xb16_cifar10.py.

@mzr1996 mzr1996 requested a review from Ezra-Yu November 17, 2021 08:50
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 7977dc8 into open-mmlab:master Nov 19, 2021
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
…rd. (open-mmlab#508)

* Update tnt config

* Rename config files

* Update docs

* Update metafile in dev_scripts

* Fix some files

* Remove fp16 metafile and README.

* Fix names in metafiles.
@mzr1996 mzr1996 deleted the config-rename branch December 7, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants