Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Deprecate the support for "python setup.py test" #646

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jan 13, 2022

Motivation

Refers to open-mmlab/mmcv#1637

Modification

Update the setup.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 changed the base branch from master to dev January 13, 2022 04:25
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@5232965). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #646   +/-   ##
======================================
  Coverage       ?   82.12%           
======================================
  Files          ?      119           
  Lines          ?     6865           
  Branches       ?     1184           
======================================
  Hits           ?     5638           
  Misses         ?     1063           
  Partials       ?      164           
Flag Coverage Δ
unittests 82.12% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5232965...9cadd36. Read the comment docs.

@mzr1996 mzr1996 merged commit a865d64 into open-mmlab:dev Jan 25, 2022
Ezra-Yu pushed a commit to Ezra-Yu/mmclassification that referenced this pull request Feb 14, 2022
…ab#646)

* Deprecate the support for "python setup.py test"

* Update requirements
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
…ab#646)

* Deprecate the support for "python setup.py test"

* Update requirements
@mzr1996 mzr1996 deleted the remove-pytest-runner branch December 7, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant