Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support CUB dataset #703

Merged
merged 14 commits into from
Mar 16, 2022
Merged

Conversation

okotaku
Copy link
Collaborator

@okotaku okotaku commented Feb 21, 2022

Motivation

Support CUB dataset.

Augmentation and optimizer is based on A Novel Plug-in Module for Fine-Grained Visual Classification.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@okotaku okotaku changed the title Cub dataset [Feature] Support CUB dataset Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #703 (013e987) into dev (c1534f9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #703      +/-   ##
==========================================
+ Coverage   84.98%   85.04%   +0.05%     
==========================================
  Files         122      123       +1     
  Lines        7573     7603      +30     
  Branches     1304     1311       +7     
==========================================
+ Hits         6436     6466      +30     
  Misses        945      945              
  Partials      192      192              
Flag Coverage Δ
unittests 84.96% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/__init__.py 100.00% <100.00%> (ø)
mmcls/datasets/cub.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1534f9...013e987. Read the comment docs.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Feb 22, 2022

Thank you for your awesome contribution, I will run some experiments to get several checkpoints and logs. That would take a little bit of time.

@Ezra-Yu Ezra-Yu mentioned this pull request Feb 22, 2022
27 tasks
@mzr1996 mzr1996 requested a review from Ezra-Yu February 23, 2022 08:55
mmcls/datasets/cub.py Outdated Show resolved Hide resolved
mmcls/datasets/cub.py Outdated Show resolved Hide resolved
okotaku and others added 2 commits February 24, 2022 09:10
Co-authored-by: Ezra-Yu <1105212286@qq.com>
@okotaku okotaku requested a review from Ezra-Yu February 24, 2022 00:21
mmcls/datasets/cub.py Outdated Show resolved Hide resolved
mmcls/datasets/cub.py Outdated Show resolved Hide resolved
@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Mar 1, 2022

I have reproduced the baseline r50(88.2) and swin-l(91.9) result in A Novel Plug-in Module for Fine-Grained Visual Classification.

Could I commit the configs and doc to your branch directly?

@okotaku
Copy link
Collaborator Author

okotaku commented Mar 1, 2022

@Ezra-Yu Sure.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Mar 2, 2022

I can not commit to your branch directly, maybe you should check the Allow edits and access to secrets by maintainers.

for example:
image

@okotaku
Copy link
Collaborator Author

okotaku commented Mar 2, 2022

@Ezra-Yu I could not run Allow edits and access to secrets by maintainers because it was not forked with my personal account. Instead, I gave you write permission and invited as collaborators. Please make sure this is okay.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Mar 2, 2022

@Ezra-Yu I could not run Allow edits and access to secrets by maintainers because it was not forked with my personal account. Instead, I gave you write permission and invited as collaborators. Please make sure this is okay.

It works.

@Ezra-Yu Ezra-Yu self-requested a review March 8, 2022 06:12
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@okotaku
Copy link
Collaborator Author

okotaku commented Mar 14, 2022

@Ezra-Yu

I noticed that the following url for the weight is NOT FOUND.
https://download.openmmlab.com/mmclassification/v0/resnet/resnet50_mill_3rdparty_in21k_20220307-bdb3a68b.pth

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Mar 14, 2022

@okotaku Yes, the weights and logs have not been uploaded to the server, I will urge this to be done.

@mzr1996 mzr1996 merged commit aa522f4 into open-mmlab:dev Mar 16, 2022
@okotaku
Copy link
Collaborator Author

okotaku commented Mar 31, 2022

@Ezra-Yu @mzr1996 This PR was released in v0.22.0, but weights and logs do not yet exist.

@mzr1996
Copy link
Member

mzr1996 commented Mar 31, 2022

@Ezra-Yu @mzr1996 This PR was released in v0.22.0, but weights and logs do not yet exist.

My bad, I will upload it soon.

@mzr1996
Copy link
Member

mzr1996 commented Mar 31, 2022

@Ezra-Yu @mzr1996 This PR was released in v0.22.0, but weights and logs do not yet exist.

Done.

mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* support cub dataset

* support cub dataset

* fix train lint error

* add docs

* fix class label

Co-authored-by: Ezra-Yu <1105212286@qq.com>

* del debug code

* skip docformatter problem

* add unit tests

* add CUB baseline configs and chpts

* fix some typos

* fix name style

* update flops

Co-authored-by: Ezra-Yu <1105212286@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants