Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Set torch seed in worker_init_fn #733

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Mar 16, 2022

Motivation

If random function of PyTorch is used in pipeline, we need to set torch seed in work_init_fn.

Modification

As the title.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu March 16, 2022 12:38
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #733 (361b25f) into dev (2037260) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #733      +/-   ##
==========================================
+ Coverage   84.93%   85.03%   +0.09%     
==========================================
  Files         121      123       +2     
  Lines        7549     7604      +55     
  Branches     1303     1311       +8     
==========================================
+ Hits         6412     6466      +54     
- Misses        945      946       +1     
  Partials      192      192              
Flag Coverage Δ
unittests 84.95% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/builder.py 91.04% <0.00%> (-1.38%) ⬇️
mmcls/datasets/__init__.py 100.00% <0.00%> (ø)
mmcls/models/utils/augment/__init__.py 100.00% <0.00%> (ø)
mmcls/models/utils/augment/resizemix.py 100.00% <0.00%> (ø)
mmcls/datasets/cub.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2037260...361b25f. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 7856141 into open-mmlab:dev Mar 16, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@mzr1996 mzr1996 deleted the workfn-seed branch December 7, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants