Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support BEiT Transformer layer #919

Merged
merged 21 commits into from Aug 16, 2022
Merged

[Feature]: Support BEiT Transformer layer #919

merged 21 commits into from Aug 16, 2022

Conversation

YuanLiuuuuuu
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #919 (5bb4e5f) into dev-1.x (b8b31e9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           dev-1.x    #919      +/-   ##
==========================================
- Coverage     0.02%   0.02%   -0.01%     
==========================================
  Files          121     121              
  Lines         8217    8334     +117     
  Branches      1368    1382      +14     
==========================================
  Hits             2       2              
- Misses        8215    8332     +117     
Flag Coverage Δ
unittests 0.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/vision_transformer.py 0.00% <0.00%> (ø)
mmcls/models/utils/__init__.py 0.00% <0.00%> (ø)
mmcls/models/utils/attention.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mzr1996 mzr1996 self-requested a review July 29, 2022 08:31
@mzr1996 mzr1996 added the 1.0rc Functionalities for MMClassification 1.0rc label Jul 29, 2022
configs/deit/deit-base_pt-cae-selfsup-8x128_in1k.py Outdated Show resolved Hide resolved
@@ -98,6 +101,109 @@ def forward(self, x):
return x


class BEiTTransformerEncoderLayer(TransformerEncoderLayer):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests.

mmcls/models/backbones/vision_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/vision_transformer.py Show resolved Hide resolved
mmcls/models/backbones/vision_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/vision_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/vision_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/vision_transformer.py Outdated Show resolved Hide resolved
mmcls/models/utils/attention.py Show resolved Hide resolved
tools/train.py Outdated Show resolved Hide resolved
@mzr1996 mzr1996 merged commit e4252d6 into open-mmlab:dev-1.x Aug 16, 2022
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* [Feature]: Add BEiT-style transformer encoder layer

* [Feature]: Add average token

* [Fix]: Fix lint

* [Fix]: Refactor CAE config

* [Fix]: Change cv2 backend to pillow backend

* [Fix]: Fix MAE and CAE reshape bug

* [Feature]: Add freeze vit layers

* [Feature]: Add mc

* [Fix]: Fix lint

* [Fix]: Fix dataset bug

* [Fix]: Delete cae selfsup config

* [Fix]: docstring

* [Refactor]: Add init_values to layer_scalue_init_value

* [Fix]: Refine the docstring of avg_token

* [Fix]: Call super init weight in beit attention

* [Fix]: remove mc

* [Fix]: Fix docstring

* [Fix]: Fix docstring

* [Fix]: Fix lint

* [Fix]: Fix init_value bug and change the logic of outputting cls token

* [Fix]: Fix docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0rc Functionalities for MMClassification 1.0rc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants