Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in msdeformattn_pixel_decoder.py #8574

Open
mtchiu2 opened this issue Aug 16, 2022 · 2 comments
Open

typo in msdeformattn_pixel_decoder.py #8574

mtchiu2 opened this issue Aug 16, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request typo
Milestone

Comments

@mtchiu2
Copy link

mtchiu2 commented Aug 16, 2022

Thanks for your error report and we appreciate it a lot.

Checklist

  1. I have searched related issues but cannot get the expected help.
  2. I have read the FAQ documentation but cannot get the expected help.
  3. The bug has not been fixed in the latest version.

Describe the bug
A clear and concise description of what the bug is.

In mmdetection/blob/master/mmdet/models/plugins/msdeformattn_pixel_decoder.py# , valid_ratios seems to be mistyped as valid_radios, effectively making this argument useless?

Bug fix
Fix typo.

@chhluo chhluo self-assigned this Aug 21, 2022
@chhluo
Copy link
Collaborator

chhluo commented Sep 5, 2022

Yes, that's a typo. Thanks.

@chhluo chhluo added the typo label Sep 6, 2022
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Nov 8, 2022

Hi @mtchiu2 ,
Thanks for your kind report. Would you like to create a PR to fix it?

@ZwwWayne ZwwWayne added the enhancement New feature or request label Nov 8, 2022
@ZwwWayne ZwwWayne added this to the 2.27.0 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request typo
Projects
None yet
Development

No branches or pull requests

4 participants