Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [3.x] May I ask the reason why the color palette value based on the model? #9309

Open
sanbuphy opened this issue Nov 13, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@sanbuphy
Copy link
Contributor

sanbuphy commented Nov 13, 2022

What's the feature?

I see this : https://github.com/open-mmlab/mmdetection/blob/3.x/mmdet/apis/inference.py#L33

        palette (str): Color palette used for visualization. If palette
            is stored in checkpoint, use checkpoint's palette first, otherwise
            use externally passed palette. Currently, supports 'coco', 'voc',
            'citys' and 'random'. Defaults to coco.

If I want to change the config palette I get an error, because the palette use checkpoint's palette first.
I don't quite understand the reason for this design , i want to use config palette to override the model palette, is it possible?

Any other context?

No response

@ZwwWayne
Copy link
Collaborator

Thanks for your kind suggestion. We will try to fix the orders. Do you think the orders below works for you?

  1. config, if it has
  2. model state_dict
  3. dataset

@ZwwWayne ZwwWayne added the v-3.x label Nov 14, 2022
@ZwwWayne ZwwWayne assigned hhaAndroid and unassigned ZwwWayne Nov 14, 2022
@sanbuphy
Copy link
Contributor Author

Thanks for your kind suggestion. We will try to fix the orders. Do you think the orders below works for you?

  1. config, if it has
  2. model state_dict
  3. dataset

Thanks a lot.
Yes, I think this order is more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants