[Fix] Fix bugs in analyze_logs
#2184
Conversation
Codecov ReportBase: 45.23% // Head: 46.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2184 +/- ##
===========================================
+ Coverage 45.23% 46.39% +1.16%
===========================================
Files 253 259 +6
Lines 20729 21401 +672
Branches 3275 3379 +104
===========================================
+ Hits 9377 9930 +553
- Misses 10733 10827 +94
- Partials 619 644 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ZwwWayne
requested review from
sunjiahao1999
and removed request for
VVsssssk
| raise KeyError( | ||
| f'{args.json_logs[i]} does not contain metric {metric}') | ||
|
|
||
| if args.mode == 'eval': |
There was a problem hiding this comment.
Why the content of mode eval has been deleted?
There was a problem hiding this comment.
The json file does not content mode key. If users want to plot evaluation metric, we can set args.eval to True.
There was a problem hiding this comment.
when i run python tools/analysis_tools/analyze_logs.py plot_curve 79.7\ 496\ 432/20230902_001556/vis_data/20230902_001556.json --keys loss --eval
i encounter :ValueError: x and y must have same first dimension, but have shapes (399,) and (400,)
whats this error?
There was a problem hiding this comment.
@Xiangxu-0103 Hi, please update this PR if you have checked the correctness of running.
Have checked this script. |
|
LGTM. |
when i run python tools/analysis_tools/analyze_logs.py plot_curve 79.7\ 496\ 432/20230902_001556/vis_data/20230902_001556.json --keys loss --eval |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Usage:
If users want to plot training parameters, take
lras an example:python tools/analysis_tools/analyze_logs.py plot_curve ${JSON_FILE} --keys lrIf users want to plot evaluation metric, take
Overall_3D_AP11_moderateas an example:BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist