Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] support all Video Super-Resolution models inferencer #1720

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Mar 28, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

python mmediting_inference_demo.py \
        --model-name edvr \
        --extra-parameters window_size=5 \
        --video input_dir \
        --result-out-dir output_dir

python mmediting_inference_demo.py \
        --model-name tdan \
        --model-setting 2 \
        --extra-parameters window_size=5 \
        --video input_dir \
        --result-out-dir output_dir

python mmediting_inference_demo.py \
        --model-name basicvsr \
        --video input_dir \
        --result-out-dir output_dir

python mmediting_inference_demo.py \
        --model-name iconvsr \
        --video input_dir \
        --result-out-dir output_dir

python mmediting_inference_demo.py \
        --model-name basicvsr_pp \
        --video input_dir \
        --result-out-dir output_dir

python mmediting_inference_demo.py \
        --model-name real_basicvsr \
        --video input_dir \
        --result-out-dir output_dir

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran requested a review from liuwenran March 28, 2023 09:16
@Z-Fran Z-Fran self-assigned this Mar 28, 2023
@Z-Fran Z-Fran linked an issue Mar 28, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fcb3914) 88.18% compared to head (e6bf64f) 88.18%.

❗ Current head e6bf64f differs from pull request most recent head b989d6c. Consider uploading reports for the commit b989d6c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1720   +/-   ##
========================================
  Coverage    88.18%   88.18%           
========================================
  Files          401      401           
  Lines        26424    26424           
  Branches      4120     4120           
========================================
  Hits         23302    23302           
  Misses        2238     2238           
  Partials       884      884           
Flag Coverage Δ
unittests 88.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/edit.py 91.76% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@liuwenran liuwenran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Z-Fran Z-Fran merged commit 6edd588 into open-mmlab:dev-1.x Mar 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No such file or directory: '00000001.png'
2 participants