New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines for FBA #209

Merged

innerlee merged 20 commits into master from ycr/pipeline

Feb 27, 2021

Contributor

yaochaorui commented Feb 25, 2021

No description provided.

codecov bot commented Feb 25, 2021 •

edited

Loading

Codecov Report

Merging #209 (c08bc95) into master (0abd0fe) will increase coverage by 0.00%.
The diff coverage is 86.53%.

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         145      145           
  Lines        6691     6732   +41     
  Branches      997     1004    +7     
=======================================
+ Hits         5505     5539   +34     
- Misses       1083     1086    +3     
- Partials      103      107    +4

Flag	Coverage Δ
unittests	`82.27% <86.53%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmedit/datasets/pipelines/__init__.py	`100.00% <ø> (ø)`
mmedit/datasets/pipelines/loading.py	`95.21% <76.92%> (-1.27%)`	⬇️
mmedit/datasets/pipelines/matting_aug.py	`94.23% <88.88%> (-0.93%)`	⬇️
mmedit/datasets/pipelines/augmentation.py	`99.16% <100.00%> (-0.01%)`	⬇️
mmedit/datasets/pipelines/crop.py	`96.81% <100.00%> (-0.02%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0abd0fe...596b594. Read the comment docs.

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated Show resolved Hide resolved

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated Show resolved Hide resolved

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated Show resolved Hide resolved

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated Show resolved Hide resolved

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated

+                      trimap[trimap_o == 255, 1] = 255
+                      clicks = np.zeros((h, w, 6))
+                      for k in range(2):
+                          if (np.count_nonzero(trimap[:, :, k]) > 0):

Contributor

innerlee Feb 25, 2021

np.any(trimap[:, :, k])

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated Show resolved Hide resolved

innerlee added the need test label

Contributor

innerlee commented Feb 25, 2021

Please add unittests for this function

yaochaorui added 4 commits

February 26, 2021 12:08


          Added pipelines for FBA.

b5dade2


          Modified.

0c611e8


          Added test.

f39af18


          Tiny.

150ce47

yaochaorui force-pushed the ycr/pipeline branch from a438fb9 to 150ce47 Compare

February 26, 2021 04:10

Contributor

innerlee commented Feb 26, 2021

Add repr

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated

+                      trimap2 = np.zeros((h, w, 2), dtype=np.uint8)
+                      trimap2[trimap == 0, 0] = 255
+                      trimap2[trimap == 255, 1] = 255
+                      trimap_trans = np.zeros((h, w, 6), dtype=np.uint8)

Contributor

innerlee Feb 26, 2021

it is float32

Contributor Author

yaochaorui Feb 26, 2021

Fixed. Sorry.

yaochaorui added 3 commits

February 26, 2021 18:32


          Added __repr__ funcs.

0766f73


          Added use_cache.

8ba75ec


          Added test.

8af8d64

innerlee removed the need test label

yaochaorui added 4 commits

February 26, 2021 19:48


          Tiny.

d1c4cc7


          Added unittest.

2c81100


          Speed up via broadcasting.

45dad85


          Tiny.

1d2c635

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated Show resolved Hide resolved

yaochaorui added 2 commits

February 27, 2021 09:25


          Use online cache.

195e50e


          Tiny.

0e90d47

innerlee reviewed

View reviewed changes

tests/test_loading.py Show resolved Hide resolved

yaochaorui added 2 commits

February 27, 2021 11:59


          Tiny.

360d322


          Simplified.

60a87da

yaochaorui added 2 commits

February 27, 2021 12:05


          Tiny。

d7ee4a1


          Tiny.

3ef2556

innerlee changed the title ~~Added pipelines for FBA.~~ Pipelines for FBA


          Tiny.

b2a4c2f

innerlee reviewed

View reviewed changes

mmedit/datasets/pipelines/matting_aug.py Outdated

+              @PIPELINES.register_module()
+              class TransformTrimap:
+                  """Generate two-channel transformed trimap.

Contributor

innerlee Feb 27, 2021

This is not two channel

yaochaorui added 2 commits

February 27, 2021 16:05


          Tiny.

72a7206


          Polished the doc string.

596b594

innerlee approved these changes

View reviewed changes

Contributor

innerlee commented Feb 27, 2021

thanks!

innerlee merged commit 4f90c0c into master

innerlee deleted the ycr/pipeline branch

February 27, 2021 11:29

Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request


          Pipelines for FBA (open-mmlab#209)

1fb2b36

* Added pipelines for FBA.

* Modified.

* Added test.

* Tiny.

* Added __repr__  funcs.

* Added use_cache.

* Added test.

* Tiny.

* Added unittest.

* Speed up via broadcasting.

* Tiny.

* Use online cache.

* Tiny.

* Tiny.

* Simplified.

* Tiny。

* Tiny.

* Tiny.

* Tiny.

* Polished the doc string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment