Add LIIF. #227
Merged
Add LIIF. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2021 20:39
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 81.79% 81.41% -0.39%
==========================================
Files 152 153 +1
Lines 7223 7413 +190
Branches 1066 1088 +22
==========================================
+ Hits 5908 6035 +127
- Misses 1191 1247 +56
- Partials 124 131 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I will take a look tonight :) |
innerlee
reviewed
Mar 31, 2021
|
There are some thing wrong with commits. |
innerlee
reviewed
Apr 1, 2021
innerlee
reviewed
Apr 1, 2021
mmedit/models/restorers/liif.py
Outdated
| # loss | ||
| self.pixel_loss = build_loss(pixel_loss) if pixel_loss else None | ||
|
|
||
| self.step_counter = 0 # counting training steps |
There was a problem hiding this comment.
What if the model is resumed
There was a problem hiding this comment.
This parameter (step_counter) is actually not used and has been deleted.
innerlee
reviewed
Apr 1, 2021
innerlee
reviewed
Apr 1, 2021
mmedit/models/restorers/liif.py
Outdated
| Returns: | ||
| dict: Returned output. | ||
| """ | ||
| # print(data_batch.keys()) |
innerlee
approved these changes
Apr 6, 2021
Yshuo-Li
added a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
* Add LIIF. * Add LIIF. * modify super init. * Add licence,optimize code. * remove debugging codes. * Modify __init__() function. * Modify test function of LIIF. Co-authored-by: 李尹硕 <SENSETIME\liyinshuo@cn0014004493l.domain.sensetime.com> Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LIIF model for single image super-resolution.
Paper: Learning Continuous Image Representation with Local Implicit Image Function
Ref repo: https://github.com/yinboc/liif.git