Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRResize #295

Merged
merged 8 commits into from
May 12, 2021
Merged

Add SRResize #295

merged 8 commits into from
May 12, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented May 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #295 (740c4b7) into master (41968e2) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 740c4b7 differs from pull request most recent head 25e23bf. Consider uploading reports for the commit 25e23bf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   80.54%   80.47%   -0.08%     
==========================================
  Files         162      162              
  Lines        8091     8035      -56     
  Branches     1192     1193       +1     
==========================================
- Hits         6517     6466      -51     
+ Misses       1429     1425       -4     
+ Partials      145      144       -1     
Flag Coverage Δ
unittests 80.47% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/pipelines/sr_resize.py 92.30% <100.00%> (ø)
...ackbones/encoder_decoders/pconv_encoder_decoder.py 43.47% <0.00%> (-2.36%) ⬇️
mmedit/models/base.py 82.75% <0.00%> (-2.09%) ⬇️
...ones/encoder_decoders/two_stage_encoder_decoder.py 53.84% <0.00%> (-1.16%) ⬇️
...dels/backbones/encoder_decoders/encoders/resnet.py 66.01% <0.00%> (-0.97%) ⬇️
...s/backbones/encoder_decoders/gl_encoder_decoder.py 81.48% <0.00%> (-0.67%) ⬇️
mmedit/datasets/pipelines/normalization.py 88.88% <0.00%> (-0.59%) ⬇️
mmedit/models/mattors/indexnet.py 84.37% <0.00%> (-0.48%) ⬇️
mmedit/models/mattors/base_mattor.py 84.94% <0.00%> (-0.48%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613b260...25e23bf. Read the comment docs.

@innerlee
Copy link
Contributor

It seems that the difference between this and the Resize https://github.com/open-mmlab/mmediting/blob/master/mmedit/datasets/pipelines/augmentation.py#L13 is that, here it allows specifying the "input_key", "output_key", and "backend".
So, how about enhancing the Resize instead of making a new one?

@Yshuo-Li
Copy link
Collaborator Author

It seems that the difference between this and the Resize https://github.com/open-mmlab/mmediting/blob/master/mmedit/datasets/pipelines/augmentation.py#L13 is that, here it allows specifying the "input_key", "output_key", and "backend".
So, how about enhancing the Resize instead of making a new one?

Here is resize for SR, which is different from the resize in augmentation. Can I rename it to SRResize?

@innerlee innerlee changed the title Add Resampling Add SRResize May 12, 2021
@innerlee
Copy link
Contributor

Conflicts with master now

@Yshuo-Li Yshuo-Li requested a review from innerlee May 12, 2021 07:03
@innerlee innerlee merged commit d2a4142 into open-mmlab:master May 12, 2021
@Yshuo-Li Yshuo-Li deleted the resampling branch June 19, 2021 03:02
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* Add ReSampling

* Add ReSampling

* Fix docstring

* fix

* add generate-by-resize

* Rename

* update docstring

Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants