Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add tensorrt evaluation #328

Merged
merged 14 commits into from
May 31, 2021
Merged

Conversation

AllentDan
Copy link
Member

Mainly changes the following files:
.gitignore: add onnx and tensorrt file and local history
docs/tools_scripts.md: add tensorrt evaluation results
tools/deploy_test.py: add tensorrt evaluation parts

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #328 (1b4ad24) into master (98a7ca3) will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   80.76%   80.03%   -0.73%     
==========================================
  Files         171      178       +7     
  Lines        8526     9332     +806     
  Branches     1234     1357     +123     
==========================================
+ Hits         6886     7469     +583     
- Misses       1488     1674     +186     
- Partials      152      189      +37     
Flag Coverage Δ
unittests 80.02% <ø> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/losses/perceptual_loss.py 56.75% <0.00%> (-1.58%) ⬇️
mmedit/models/backbones/__init__.py 100.00% <0.00%> (ø)
mmedit/models/restorers/__init__.py 100.00% <0.00%> (ø)
mmedit/models/components/__init__.py 100.00% <0.00%> (ø)
mmedit/models/backbones/sr_backbones/__init__.py 100.00% <0.00%> (ø)
mmedit/models/backbones/sr_backbones/tdan_net.py 35.29% <0.00%> (ø)
.../models/backbones/sr_backbones/glean_styleganv2.py 97.00% <0.00%> (ø)
mmedit/models/restorers/glean.py 63.33% <0.00%> (ø)
mmedit/models/components/stylegan2/__init__.py 100.00% <0.00%> (ø)
mmedit/models/components/stylegan2/modules.py 64.40% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a7ca3...1b4ad24. Read the comment docs.


We provide methods to evaluate TensorRT and ONNX models in `tools/deploy_test.py`. To evaluate ONNX models, onnxruntime should be installed first.

#### Prerequisite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to install TensorRT as well for the evaluation of TensorRT models.


#### Results and Models

<table class="tg">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the format of html table the same as before. For instance, the class attribute.
You can check generated HTML pages by following instructions:

  • Generate HTML pages.
pip install recommonmark sphinx_markdown_tables sphinx_rtd_theme
cd docs
make html
  • Then view the related HTML files with the browser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I used Table Generator. But your advise will be taken.

@RunningLeon RunningLeon requested a review from innerlee May 28, 2021 11:35
tools/deploy_test.py Outdated Show resolved Hide resolved
tools/deploy_test.py Outdated Show resolved Hide resolved
@innerlee
Copy link
Contributor

Some minor style change

@innerlee innerlee merged commit 8745a33 into open-mmlab:master May 31, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* trt_test

* remove history

* remove history

* remove history

* use html table

* use html table

* use html table

* eval tensorrt

* merge

* merge into one table

* specify all the prerequistes

* render table

* fix lint

* minor style change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants