-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add HourGlass #341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 80.03% 80.10% +0.06%
==========================================
Files 178 179 +1
Lines 9332 9363 +31
Branches 1357 1360 +3
==========================================
+ Hits 7469 7500 +31
Misses 1674 1674
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
||
def __init__(self, depth, mid_channels): | ||
super().__init__() | ||
self.up1 = ResBlock(mid_channels, mid_channels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an upsampling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give it a better name :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Digged a little about the history. mmpose's version comes from mmdet open-mmlab/mmdetection#2840.
It is a bad naming. However since it has been existed in multiple mm-repos, let's keep it for now.
return x + residual | ||
|
||
|
||
class HourGlass(nn.Module): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any relationship with this? https://github.com/open-mmlab/mmpose/blob/master/mmpose/models/backbones/hourglass.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referred to this file.
* [Feature] Add HourGlass * update unittest * Update Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Part of DIC
HourGlass --> FeedbackHourGlass --> DIC