Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add HourGlass #341

Merged
merged 3 commits into from
Jun 1, 2021
Merged

[Feature] Add HourGlass #341

merged 3 commits into from
Jun 1, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented May 29, 2021

Part of DIC
HourGlass --> FeedbackHourGlass --> DIC

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #341 (a695df1) into master (6238c69) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   80.03%   80.10%   +0.06%     
==========================================
  Files         178      179       +1     
  Lines        9332     9363      +31     
  Branches     1357     1360       +3     
==========================================
+ Hits         7469     7500      +31     
  Misses       1674     1674              
  Partials      189      189              
Flag Coverage Δ
unittests 80.09% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/extractors/__init__.py 100.00% <100.00%> (ø)
mmedit/models/extractors/feedback_hour_glass.py 100.00% <100.00%> (ø)
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6238c69...a695df1. Read the comment docs.


def __init__(self, depth, mid_channels):
super().__init__()
self.up1 = ResBlock(mid_channels, mid_channels)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an upsampling?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a better name :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digged a little about the history. mmpose's version comes from mmdet open-mmlab/mmdetection#2840.

It is a bad naming. However since it has been existed in multiple mm-repos, let's keep it for now.

return x + residual


class HourGlass(nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@Yshuo-Li Yshuo-Li May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referred to this file.

@innerlee innerlee merged commit c6f0ce2 into open-mmlab:master Jun 1, 2021
@Yshuo-Li Yshuo-Li deleted the hg branch June 19, 2021 03:02
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Add HourGlass

* update unittest

* Update

Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants