Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add TDAN config and models #347

Merged
merged 4 commits into from Jun 1, 2021
Merged

[Feature] Add TDAN config and models #347

merged 4 commits into from Jun 1, 2021

Conversation

ckkelvinchan
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 31, 2021 •
edited

Codecov Report

Merging #347 (88310ad) into master (290c75e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 88310ad differs from pull request most recent head 664a8f2. Consider uploading reports for the commit 664a8f2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   79.98%   79.96%   -0.03%     
==========================================
  Files         180      180              
  Lines        9435     9435              
  Branches     1377     1377              
==========================================
- Hits         7547     7545       -2     
- Misses       1698     1699       +1     
- Partials      190      191       +1
Flag Coverage Δ
unittests 79.95% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290c75e...664a8f2. Read the comment docs.

@innerlee
Copy link
Contributor

innerlee commented May 31, 2021 •
edited

As discussed in private, need to add training steps in the algorithm's README

innerlee
innerlee reviewed Jun 1, 2021
View reviewed changes
configs/restorers/tdan/README.md Outdated
@@ -33,14 +33,16 @@ You can use the following command to train a model.
./tools/dist_train.sh ${CONFIG_FILE} ${GPU_NUM} [optional arguments]
```

TDAN is trained with two stages. For example, when training on Bicubic downsampling, you need to use
TDAN is trained with two stages. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example:

@innerlee innerlee merged commit 085a277 into open-mmlab:master Jun 1, 2021
@ckkelvinchan ckkelvinchan deleted the tdan_config branch June 1, 2021 03:47
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@ckkelvinchan
[Feature] Add TDAN config and models (open-mmlab#347)
ccab555 
* Add TDAN config and models

* Add training and test descriptions

* Update readme descrptions

* Update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckkelvinchan @innerlee