Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add basic tutorial for SR models #380

Merged
merged 2 commits into from
Jul 3, 2021

Conversation

ckkelvinchan
Copy link
Member

Motivation

A demo teaching users how to train and test existing models could help them get familiar with MMEditing.

Modification

This PR adds a basic tutorial for SR models. It includes both image and video SR models.

Remarks

There is a link to the comprehensive models, but the link hasn't been added.

@ckkelvinchan
Copy link
Member Author

Please feel free to leave comments :)

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #380 (4e5cb43) into master (7328829) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4e5cb43 differs from pull request most recent head 8444e5f. Consider uploading reports for the commit 8444e5f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   80.44%   80.42%   -0.03%     
==========================================
  Files         185      185              
  Lines        9889     9889              
  Branches     1441     1441              
==========================================
- Hits         7955     7953       -2     
- Misses       1742     1743       +1     
- Partials      192      193       +1     
Flag Coverage Δ
unittests 80.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7328829...8444e5f. Read the comment docs.

@innerlee
Copy link
Contributor

innerlee commented Jul 1, 2021

See the installation step here https://github.com/open-mmlab/mmocr/blob/main/demo/MMOCR_Tutorial.ipynb
The mmcv-full is generally installed manually

edit:
also add a colab badge as in the above file. Try to run the whole file in colab to make sure it can run there

@ckkelvinchan
Copy link
Member Author

See the installation step here https://github.com/open-mmlab/mmocr/blob/main/demo/MMOCR_Tutorial.ipynb
The mmcv-full is generally installed manually

edit:
also add a colab badge as in the above file. Try to run the whole file in colab to make sure it can run there

Note that the cell training and testing on pre-defined datasets are not expected to be run. It is used as a demo showing users how to use the command.

@ckkelvinchan
Copy link
Member Author

It has been tested on colab.

@innerlee
Copy link
Contributor

innerlee commented Jul 2, 2021

The file cannot be displayed by github. Please check if the format is correct.

Rebase master btw :)

@innerlee innerlee merged commit 5ba604d into open-mmlab:master Jul 3, 2021
@ckkelvinchan ckkelvinchan deleted the tut branch July 8, 2021 03:12
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* Add basic tutorial

* Modify installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants