Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate config.md and config_restoration.md #442

Merged
merged 12 commits into from
Aug 5, 2021
Merged

Translate config.md and config_restoration.md #442

merged 12 commits into from
Aug 5, 2021

Conversation

AlexZou14
Copy link
Contributor

我可以继续把这个翻译一下tools/data/super-resolution/*/README.md

@innerlee
Copy link
Contributor

Please rebase current branch onto master.

git checkout master
git pull
git checkout cndocs
git rebase master
git push -f

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #442 (b004496) into master (5df0da9) will not change coverage.
The diff coverage is n/a.

❗ Current head b004496 differs from pull request most recent head 5bbe10f. Consider uploading reports for the commit 5bbe10f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         189      189           
  Lines       10149    10149           
  Branches     1495     1495           
=======================================
  Hits         8213     8213           
  Misses       1721     1721           
  Partials      215      215
Flag Coverage Δ
unittests 80.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df0da9...5bbe10f. Read the comment docs.

@AlexZou14
Copy link
Contributor Author

我已经rebase过了 请问还需要怎么做呀

@ckkelvinchan
Copy link
Member

我已经rebase过了 请问还需要怎么做呀

Hello 你好, 從 unittest 看到 lint failed 了, 一般我們會用 pre-commit 去 format 格式。

你可以先pip install pre-commit, 然後在你的 directory 裡輸入 pre-commit install , 這樣 push 的時候就會檢查和修正格式。

ckkelvinchan
ckkelvinchan reviewed Aug 3, 2021
View reviewed changes
Copy link
Member

@ckkelvinchan ckkelvinchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove another two files. They are not necessary.

docs_zh-CN/config_restoration.md Outdated
@@ -1 +1,156 @@
# 配置文件 - 复原

## 示例-EDSR
为了帮助用户理解mmediting的配置文件结构，这里以EDSR为例，给出其配置文件的注释。对于每个模块的详细用法以及对应参数的选择，请参照 API 文档。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing when switching chinese and english

AlexZou14 and others added 12 commits August 5, 2021 09:22
@AlexZou14 @innerlee
Add Chinese translation of config.md and config_restoration.md
85bff60
@AlexZou14 @innerlee
Add Chinese translation of config.md and config_restoration.md
617b325 
Add Chinese translation of config.md
@AlexZou14 @innerlee
Revert "Add Chinese translation of config.md and config_restoration.md"
141cc5b 
This reverts commit 520bf30.
@AlexZou14 @innerlee
Add Chinese translation of Config.md.
d45b780
@AlexZou14 @innerlee
Add Chinese translation of config.md and config_restoration.md
c018d78
@innerlee
Revise
17b5e45 
Signed-off-by: lizz <lizz@sensetime.com>
@innerlee
Imrpove
77618e9 
Signed-off-by: lizz <lizz@sensetime.com>
@AlexZou14 @innerlee
@AlexZou14 Add Chinese translation of config.md and config_restoratio…
33ee9da 
…n.md
@AlexZou14 @innerlee
fix config_restoration.md
618577a
@innerlee
rm useless files
137e6c5 
Signed-off-by: lizz <lizz@sensetime.com>
@innerlee
format
3f8e9ca 
Signed-off-by: lizz <lizz@sensetime.com>
@innerlee
space
5bbe10f 
Signed-off-by: lizz <lizz@sensetime.com>
@innerlee innerlee merged commit 53aa19b into open-mmlab:master Aug 5, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@AlexZou14 @innerlee
Translate config.md and config_restoration.md (open-mmlab#442)
a41bc94 
* Add Chinese translation of config.md and config_restoration.md

* Add Chinese translation of config.md and config_restoration.md

Add Chinese translation of config.md

* Revert "Add Chinese translation of config.md and config_restoration.md"

This reverts commit 520bf30.

* Add Chinese translation of Config.md.

* Add Chinese translation of config.md and config_restoration.md

* Revise

Signed-off-by: lizz <lizz@sensetime.com>

* Imrpove

Signed-off-by: lizz <lizz@sensetime.com>

* @AlexZou14 Add Chinese translation of config.md and config_restoration.md

* fix config_restoration.md

* rm useless files

Signed-off-by: lizz <lizz@sensetime.com>

* format

Signed-off-by: lizz <lizz@sensetime.com>

* space

Signed-off-by: lizz <lizz@sensetime.com>

Co-authored-by: lizz <lizz@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckkelvinchan ckkelvinchan ckkelvinchan left review comments

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexZou14 @innerlee @ckkelvinchan