Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update FixedCrop for list #682

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

FixedCrop will support list type

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #682 (b176163) into master (13e51b4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   80.65%   80.69%   +0.03%     
==========================================
  Files         199      199              
  Lines       11371    11383      +12     
  Branches     1818     1822       +4     
==========================================
+ Hits         9171     9185      +14     
+ Misses       1916     1915       -1     
+ Partials      284      283       -1     
Flag Coverage Δ
unittests 80.66% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/crop.py 97.35% <100.00%> (+0.10%) ⬆️
mmedit/datasets/pipelines/random_degradations.py 94.68% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e51b4...b176163. Read the comment docs.

Copy link
Member

@ckkelvinchan ckkelvinchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. One minor comment.

@@ -183,16 +187,26 @@ def __call__(self, results):

for k in self.keys:
# In fixed crop for paired images, sizes should be the same
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move line 189 to line 197.

@ckkelvinchan ckkelvinchan merged commit 8dce073 into open-mmlab:master Dec 22, 2021
@Yshuo-Li Yshuo-Li deleted the update-crop branch April 7, 2022 08:04
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants