Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add BaseVFIDataset #695

Merged
merged 6 commits into from
Jan 17, 2022
Merged

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented Jan 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #695 (ab882da) into master (61dfdd6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   81.35%   81.39%   +0.04%     
==========================================
  Files         202      203       +1     
  Lines       11625    11655      +30     
  Branches     1868     1875       +7     
==========================================
+ Hits         9457     9487      +30     
  Misses       1873     1873              
  Partials      295      295              
Flag Coverage Δ
unittests 81.38% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/base_vfi_dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61dfdd6...ab882da. Read the comment docs.

@Yshuo-Li Yshuo-Li changed the title [Feature] Add BaseVIDataset [Feature] Add BaseVFIDataset Jan 5, 2022
Copy link
Member

@ckkelvinchan ckkelvinchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines are not covered by unittests.

Moreover, please check if a dataset contains multiple videos with different number of frames, how the PSNR is calculated. In video SR, we usually compute the average PSNR of each video, and then take the average of all videos, as shown here.

@Yshuo-Li
Copy link
Collaborator Author

Some lines are not covered by unittests.

Moreover, please check if a dataset contains multiple videos with different number of frames, how the PSNR is calculated. In video SR, we usually compute the average PSNR of each video, and then take the average of all videos, as shown here.

If a dataset contains multiple videos with different numbers of frames, it should inherit the basic class and modify this function.

@ckkelvinchan
Copy link
Member

Some lines are not covered by unittests.
Moreover, please check if a dataset contains multiple videos with different number of frames, how the PSNR is calculated. In video SR, we usually compute the average PSNR of each video, and then take the average of all videos, as shown here.

If a dataset contains multiple videos with different numbers of frames, it should inherit the basic class and modify this function.

So this dataset is for N frames -> 1 frame case?

@Yshuo-Li
Copy link
Collaborator Author

Some lines are not covered by unittests.
Moreover, please check if a dataset contains multiple videos with different number of frames, how the PSNR is calculated. In video SR, we usually compute the average PSNR of each video, and then take the average of all videos, as shown here.

If a dataset contains multiple videos with different numbers of frames, it should inherit the basic class and modify this function.

So this dataset is for N frames -> 1 frame case?

Yes, 2 frames -> 1 frame

@ckkelvinchan ckkelvinchan merged commit 7ead844 into open-mmlab:master Jan 17, 2022
@Yshuo-Li Yshuo-Li deleted the fi-dataset branch January 17, 2022 05:32
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants