-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add BaseVFIDataset #695
Conversation
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 81.35% 81.39% +0.04%
==========================================
Files 202 203 +1
Lines 11625 11655 +30
Branches 1868 1875 +7
==========================================
+ Hits 9457 9487 +30
Misses 1873 1873
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some lines are not covered by unittests.
Moreover, please check if a dataset contains multiple videos with different number of frames, how the PSNR is calculated. In video SR, we usually compute the average PSNR of each video, and then take the average of all videos, as shown here.
If a dataset contains multiple videos with different numbers of frames, it should inherit the basic class and modify this function. |
So this dataset is for |
Yes, 2 frames -> 1 frame |
No description provided.